[TwigBridge] Removed strict check when found variables inside a translation #10643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
goetas
commented
Apr 7, 2014
goetas
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no? |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #10638 |
| License | MIT |
|
Tests are broken on PHP 5.3. |
|
I've fixed the tests. May be useful to create a single commit? |
| @@ -36,7 +36,7 @@ public function compile(\Twig_Compiler $compiler) | |||
| $defaults = $this->getNode('vars'); | |||
| $vars = null; | |||
| } | |||
| list($msg, $defaults) = $this->compileString($this->getNode('body'), $defaults); | |||
| list($msg, $defaults) = $this->compileString($this->getNode('body'), $defaults, !!$vars); | |||
There was a problem hiding this comment.
please use (Boolean) to cast to boolean rather than !!. This trick can be used in JS to be shorter, but we don't have this constraint in PHP
goetas
changed the title
|
news on this? |
|
Thanks for fixing this bug @goetas. |
fabpot
added a commit
that referenced
this pull request
Apr 28, 2014
…ide a translation (goetas) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #10643). Discussion ---------- [TwigBridge] Removed strict check when found variables inside a translation | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no? | Deprecations? | no | Tests pass? | yes | Fixed tickets | #10638 | License | MIT Commits ------- 074191e Removed strict check when found variables inside a translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.