try catch doesn't work cause of the ErrorHandler.php and HandledErrorException.php

[crashbtz]

I have a question about the method handleWith() define in HandledErrorException.php and call in ErrorHandler.php line 176.

Here is my test code in my Action:

try {
    $value = 5 / 0;
} catch (\Exception $e) {
    echo $e->getMessage();
//    throw $e;
}
return new Response('test');

When I do that, I want to catch the Exception (write a message or not) and render a response.
So why does the HandledErrorException generate a template of the Exception anyway?

cf. HandledErrorException.php line 45

echo $this->handlerOutput;

We solved "this problem" (I mean for us) temporary by adding our own

set_error_handler()

which override yours after the line

Debug::enable();

in app_dev.php

I don't know if it's a good pratice or not.

Thank you

[nicolas-grekas]

HandledException are special because they have to work around bugs in PHP and around fatal error situation. The way we do this is to pre-fill a buffer that should be manually canceled when no special situation occurs. If for any reason the buffer is not cleared (especially a non catchable situation like said bug or fatal error), the buffer is outputted and at least you have some debug message to deal with.
So, I would just suggest you to add this code in your catch block (with proper use statement):

if ($e instanceof HandledErrorException) {
    $e->cleanOutput();
}

[stof]

@nicolas-grekas the issue with this is that the Debug component now requires each library catching exceptions for recovery to be aware of the component to avoid breaking things. It is not a good behavior IMO

[nicolas-grekas]

I agree, I'm working on it

[crashbtz]

thank both of you for your responses, I'm gonna do like you said @nicolas-grekas until this gonna be fix

[nicolas-grekas]

Wait a minute, I just realized that this is not new behavior: to work around https://bugs.php.net/54275 the error handler has always echoed some output. What is new with handled exceptions is that it is now possible to cancel this output. No regression at all. Am I wrong?
Still, I'll continue trying other solutions and see whats possible.

[crashbtz]

You're right, there is no regression, the new version is better thanks to the cleanOutput() method