[HttpKernel] Fixed cache behavior when TTL has expired and a default "global" TTL is defined #10896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 12, 2014
|
👍 |
1 similar comment
|
👍 |
fabpot
added a commit
that referenced
this pull request
May 13, 2014
… a default "global" TTL is defined (alquerci, fabpot) This PR was merged into the 2.3 branch. Discussion ---------- [HttpKernel] Fixed cache behavior when TTL has expired and a default "global" TTL is defined | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | #8232, #10822, #9919 | License | MIT From #9919: "When the cache is stale the `validate` method `forward` the request to the backend. A new response will be created with or without TTL configuration. If the TTL was not set then the default one should be set like in the `fetch` method." This PR fixes this issue, the tests provided in #9919 pass, and I've tweaked them to avoid the costly sleep calls. Commits ------- e3983e8 [HttpKernel] fixed default TTL not applied under certain conditions bc42dae Added test when TTL has expired
fabpot
added a commit
that referenced
this pull request
May 15, 2014
…sts (jakzal) This PR was merged into the 2.4 branch. Discussion ---------- [HttpKernel] Replace sha1 with sha256 in recently added tests | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | - | License | MIT Tests were introduced in #10896 and are broken starting with 2.4, since the hashing algorithm has changed (introduced in #8609). Commits ------- 255544f [HttpKernel] Replace sha1 with sha256 in recently added tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #9919:
"When the cache is stale the
validatemethodforwardthe request to the backend. A new response will be created with or without TTL configuration. If the TTL was not set then the default one should be set like in thefetchmethod."This PR fixes this issue, the tests provided in #9919 pass, and I've tweaked them to avoid the costly sleep calls.