[Form][Validator] All index items after children are to be considered grand-children when resolving ViolationPath #11459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… grand-children when resolving ViolationPath (fixes #11458)
|
Ping @webmozart |
|
👍 |
|
Any news here? |
|
Confirmed and merged. Thanks Andrew! |
webmozart
added a commit
that referenced
this pull request
Sep 15, 2014
… considered grand-children when resolving ViolationPath (Andrew Moore) This PR was merged into the 2.3 branch. Discussion ---------- [Form][Validator] All index items after children are to be considered grand-children when resolving ViolationPath | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | unsure, see note below | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11458 | License | MIT | Doc PR | - #### Possible BC Break The old behavior had unit test cases specifically testing the case of a grand-children form. However, this behavior is not documented anywhere and the fix seems to have no adverse effects on form validation. `Symfony\Component\Form\FormInterface` implements `ArrayAccess`, therefore, semantically speaking, `children[direct_child].children[grand_children]` and `children[direct_child][grand_children]` are equivalent. `offsetGet` is expected to fetch an element from `children`. I do not see why both were not considered equivalent when resolving the ViolationPath. This commit will indeed change how some errors are mapped. However since the old mapping is (in my opinion) a bug... Commits ------- c64a75f [Form][Validator] All index items after children are to be considered grand-children when resolving ViolationPath (fixes #11458)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible BC Break
The old behavior had unit test cases specifically testing the case of a grand-children form. However, this behavior is not documented anywhere and the fix seems to have no adverse effects on form validation.
Symfony\Component\Form\FormInterfaceimplementsArrayAccess, therefore, semantically speaking,children[direct_child].children[grand_children]andchildren[direct_child][grand_children]are equivalent.offsetGetis expected to fetch an element fromchildren. I do not see why both were not considered equivalent when resolving the ViolationPath.This commit will indeed change how some errors are mapped. However since the old mapping is (in my opinion) a bug...