Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Validator] Translations - Call for people to add some translations for locale: af, ar, bg, cy, da, el, et, eu, fa, fi, gl, he, hr, hy, id, lb, mn, nb, no, ro, sq, sr_Cyrl, sr_Latn, th, tr, uk, vi, zh_CH, zh_TW #11489

Closed
1emming opened this issue Jul 27, 2014 · 15 comments
Closed

[Validator] Translations - Call for people to add some translations for locale: af, ar, bg, cy, da, el, et, eu, fa, fi, gl, he, hr, hy, id, lb, mn, nb, no, ro, sq, sr_Cyrl, sr_Latn, th, tr, uk, vi, zh_CH, zh_TW #11489

1emming opened this issue Jul 27, 2014 · 15 comments
Labels
Validator

Comments

@1emming
Copy link
Contributor

1emming commented Jul 27, 2014

Hello!

Here is the new list for master :)
(up to 8725243

Validator
/src/Symfony/Component/Validator/Resources/translations

Missing ids

Locale Message ids
af 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78
ar 73 74 75 76 77 78
bg 73 74 75 76 77 78
cy 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78
da 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78
el 73 74 75 76 77 78
et 73 74 75 76 77 78
eu 73 74 75 76 77 78
fa 73 74 75 76 77 78
fi 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78
gl 73 74 75 76 77 78
he 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78
hr 73 74 75 76 77 78
hy 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78
id 73 74 75 76 77 78
lb 78
mn 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78
nb 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78
no 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78
ro 73 74 75 76 77 78
sq 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78
sr_Cyrl 78
sr_Latn 78
th 78
tr 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78
uk 73 74 75 76 77 78
vi 73 74 75 76 77 78
zh_CN 73 74 75 76 77 78
zh_TW 73 74 75 76 77 78

Number of options differences:
translation id (# of options in 'en', # of options in 'locale')

Locale Message ids
ar 19 (2-6) 21 (2-6) 48 (2-6) 54 (2-6) 55 (2-6) 56 (2-6) 6 (2-6) 7 (2-6)
ca 21 (2-1)
cs 19 (2-3) 21 (2-3) 48 (2-3) 54 (2-3) 55 (2-3) 56 (2-3) 6 (2-3) 7 (2-3)
cy 19 (2-1) 21 (2-1) 48 (2-1) 54 (2-1) 55 (2-1) 56 (2-1) 6 (2-1) 7 (2-1)
da 19 (2-1) 21 (2-1) 48 (2-1) 6 (2-1) 7 (2-1)
et 19 (2-1) 21 (2-1) 48 (1-2) 54 (1-2) 55 (1-2) 56 (1-3) 6 (2-1) 7 (2-1)
fi 19 (2-1) 21 (2-1) 6 (2-1) 7 (2-1)
hr 19 (2-1) 21 (2-1) 48 (2-1) 54 (2-3) 55 (2-3) 56 (2-3) 6 (2-1) 7 (2-1)
hy 19 (2-1) 21 (2-1) 48 (2-1) 6 (2-1) 7 (2-1)
id 19 (2-1) 21 (2-1) 48 (2-1) 54 (2-1) 55 (2-1) 56 (2-1) 6 (2-1) 7 (2-1)
ja 19 (2-1) 21 (2-1) 48 (2-1) 54 (2-1) 55 (2-1) 56 (2-1) 6 (2-1) 7 (2-1)
lb 19 (2-1) 21 (2-1) 54 (2-1) 55 (2-1) 6 (2-1) 7 (2-1)
lt 19 (2-3) 21 (2-3) 48 (2-3) 54 (2-3) 55 (2-3) 56 (2-3) 6 (2-3) 7 (2-3)
mn 19 (2-1) 21 (2-1) 6 (2-1) 7 (2-1)
nb 19 (2-1) 21 (2-1) 6 (2-1) 7 (2-1)
no 19 (2-1) 21 (2-1) 48 (2-1) 6 (2-1) 7 (2-1)
pl 19 (2-3) 21 (2-3) 48 (2-3) 54 (2-1) 55 (2-1) 56 (2-3) 6 (2-3) 7 (2-3)
pt 19 (2-1) 48 (2-1)
ro 19 (2-3) 21 (2-3) 48 (2-3) 54 (2-3) 55 (2-3) 56 (2-3) 6 (2-3) 7 (2-3)
ru 19 (2-3) 21 (2-3) 48 (2-3) 54 (2-3) 55 (2-3) 56 (2-3) 6 (2-3) 7 (2-3)
sk 19 (2-3) 21 (2-3) 48 (2-3) 54 (2-3) 55 (2-3) 56 (2-3) 6 (2-3) 7 (2-3)
sl 19 (2-4) 21 (2-4) 48 (2-4) 54 (2-4) 55 (2-4) 56 (2-4) 6 (2-4) 7 (2-4)
sr_Cyrl 19 (2-3) 21 (2-3) 48 (2-3) 54 (2-3) 55 (2-3) 56 (2-3) 6 (2-3) 7 (2-3)
sr_Latn 19 (2-3) 21 (2-3) 48 (2-3) 54 (2-3) 55 (2-3) 56 (2-3) 6 (2-3) 7 (2-3)
th 19 (2-1) 21 (2-1) 48 (2-1) 54 (2-1) 55 (2-1) 56 (2-1) 6 (2-1) 7 (2-1)
tr 19 (2-1) 21 (2-1) 48 (2-1) 54 (2-1) 55 (2-1) 56 (2-1) 6 (2-1) 7 (2-1)
uk 19 (2-3) 21 (2-3) 48 (2-3) 54 (2-3) 55 (2-3) 56 (2-3) 6 (2-3) 7 (2-1)
zh_CN 19 (2-1) 21 (2-1) 48 (2-1) 54 (2-1) 55 (2-1) 56 (2-1) 6 (2-1) 7 (2-1)
zh_TW 19 (2-1) 21 (2-1) 48 (2-1) 54 (2-1) 55 (2-1) 56 (2-1) 6 (2-1) 7 (2-1)
@sprain
Copy link
Contributor

sprain commented Jul 28, 2014

I don't understand your lists. Which de translations are missing?

@1emming
Copy link
Contributor Author

1emming commented Jul 28, 2014

/src/Symfony/Component/Validator/Resources/translations/validators/validators.de.xlf
(https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Validator/Resources/translations/validators.de.xlf)

is missing:

<trans-unit id="78">
      <source>An empty file is not allowed.</source>
      <target>[ missing translation in German ]</target>
</trans-unit>

@mmoreram
Copy link
Contributor

@1emming Where can we find the original strings?

@javiereguiluz
Copy link
Member

@mmoreram the English version of each file is the canonical reference for all of them.

@dcsg
Copy link
Member

dcsg commented Jul 31, 2014

I am going to do the pt_PT translations

@mmoreram
Copy link
Contributor

I understand, but for example, in /src/Symfony/Component/Form/Resources/translations english versions for 28, 29 and 30 are not defined. ASAP I find the real translations for all of them, I can do ca and es

@javiereguiluz
Copy link
Member

I don't know what might be happening, but in src/Symfony/Component/Form/Resources/translations/validators.en.xlf file I can see those translations:

<trans-unit id="28">
    <source>This form should not contain extra fields.</source>
    <target>This form should not contain extra fields.</target>
</trans-unit>
<trans-unit id="29">
    <source>The uploaded file was too large. Please try to upload a smaller file.</source>
    <target>The uploaded file was too large. Please try to upload a smaller file.</target>
</trans-unit>
<trans-unit id="30">
    <source>The CSRF token is invalid. Please try to resubmit the form.</source>
    <target>The CSRF token is invalid. Please try to resubmit the form.</target>
</trans-unit>

@dcsg
Copy link
Member

dcsg commented Jul 31, 2014

@javiereguiluz yes and they also exist for pt that is the same for pt_PT

@wouterj
Copy link
Member

wouterj commented Jul 31, 2014

The tables are very hard to read. Can you maybe change it to only show the missing IDs, instead of the existing IDs? And for instance, "/src/Symfony/Component/Form/Resources/translations" is complete, it should be removed.

@1emming
Copy link
Contributor Author

1emming commented Jul 31, 2014

@mmoreram @dcsg @wouterj thank you for looking into this and your comments.
For now I removed the completed tables and languages. I'll update my script that generated the tables and ids to only list missing ones later on (I'm at work, script is at home :( ). After the adjustments I'll run it again against master and update the ticket where needed.

@dcsg pt_PT and pt are complete, that is why I didn't listed it in the title of this report. Thanks for looking into this and please keep providing translations in the future! :)

@mmoreram please add the ca ones, thanks! (es is complete I think)

@mmoreram
Copy link
Contributor

Yes I'll do :) Thanks @1emming

@wouterj
Copy link
Member

wouterj commented Jul 31, 2014

@1emming great, thanks for taking care of this one!

@xabbuh xabbuh mentioned this issue Jul 31, 2014
Merged
@mmoreram mmoreram mentioned this issue Jul 31, 2014
Closed
fabpot added a commit that referenced this issue Aug 1, 2014
@fabpot
minor #11528 [Validator] German translation for empty file errors (xa…
137db21 
…bbuh)

This PR was merged into the 2.6-dev branch.

Discussion
----------

[Validator] German translation for empty file errors

| Q             | A
| ------------- | ---
| Fixed tickets | part of #11489
| License       | MIT

Commits
-------

412f04f [Validator] German translation for empty file errors
fabpot added a commit that referenced this issue Aug 1, 2014
@fabpot
minor #11534 Issue #11489 Translated 78 in Català (mmoreram)
c812379 
This PR was merged into the 2.6-dev branch.

Discussion
----------

Issue #11489 Translated 78 in Català

Just 78 is created because 73 to 77 are in another PR to branch 2.4.

Commits
-------

88eac04 Issue #11532 Translated 78 in Català
fabpot added a commit that referenced this issue Aug 1, 2014
@fabpot
minor #11533 Issue #11489 Added some CA and ES translations (mmoreram)
69e8100 
This PR was merged into the 2.4 branch.

Discussion
----------

Issue #11489 Added some CA and ES translations

* Added some translations in CA
* Fixed some translations in ES

Commits
-------

67a6b75 Issue #11489 Added some CA and ES translations
@xabbuh
Copy link
Member

xabbuh commented Aug 1, 2014

@1emming Maybe it's better to sort the list by locale.

@dcsg
Copy link
Member

dcsg commented Aug 1, 2014

@1emming sorry but the list is not correct pt and pt_BR have all ids listed

@vincentaubert vincentaubert mentioned this issue Aug 2, 2014
Merged
fabpot added a commit that referenced this issue Aug 3, 2014
@fabpot
minor #11546 [Validator] refs #11489 add some translations in french …
3ecf685 
…(vincentaubert)

This PR was merged into the 2.6-dev branch.

Discussion
----------

[Validator] refs #11489 add some translations in french

| Q             | A
| ------------- | ---
| Fixed tickets | part of #11489
| License       | MIT

fixes some FR translations

Commits
-------

50791c6 [Validator] refs #11489 add some translations in french
@Nyholm Nyholm mentioned this issue Aug 4, 2014
Merged
fabpot added a commit that referenced this issue Aug 4, 2014
@fabpot
minor #11561 [Validator] Added Swedish translations (Nyholm)
a4ec72e 
This PR was merged into the 2.4 branch.

Discussion
----------

[Validator] Added Swedish translations

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | part of #11489
| License       | MIT

Added some missing Swedish translations.

Should I make an additional PR to `master` for the `trans-unit id=78` ([ref](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Validator/Resources/translations/validators.en.xlf#L302))? Or should I add that in this PR?

Commits
-------

a361f10 [Validator] Added Swedish translations
webmozart added a commit that referenced this issue Aug 5, 2014
@webmozart
Merge branch '2.4' into 2.5
98c0621 
* 2.4: (24 commits)
  [Validator] Added Swedish translations
  Fix incorrect romanian plural translations
  fix axes handling in Crawler::filterXPath()
  fix some docblocks
  Fixed self-reference in 'service_container' service breaks garbage collection (and clone).
  [Process] Fix tests when pcntl is not available.
  [DependencyInjection] Roll back changes made to generated files.
  [Console] Roll back changes made to fixture files.
  Issue #11489 Added some CA and ES translations
  [Validator] Added more detailed inline documentation
  [Validator] Removed information from the violation output if the value is an array, object or resource
  partially reverted previous commit
  fixed CS
  properly handle null data when denormalizing
  [Validator] Renamed valueToString() to formatValue(); added missing formatValue() calls
  [Validator] Fixed CS
  [Validator] Fixed date-to-string conversion tests to match ICU 51
  [Validator] Added "{{ value }}" parameters where they were missing
  [Validator] Simplified and explained the LuhnValidator
  [Validator] Simplified IssnValidator
  ...

Conflicts:
	src/Symfony/Bridge/Propel1/Form/ChoiceList/ModelChoiceList.php
	src/Symfony/Component/HttpKernel/Debug/TraceableEventDispatcher.php
	src/Symfony/Component/Security/Core/Encoder/BasePasswordEncoder.php
	src/Symfony/Component/Validator/Constraints/ChoiceValidator.php
	src/Symfony/Component/Validator/Constraints/CollectionValidator.php
	src/Symfony/Component/Validator/Constraints/FileValidator.php
	src/Symfony/Component/Validator/Constraints/Isbn.php
	src/Symfony/Component/Validator/Constraints/IsbnValidator.php
	src/Symfony/Component/Validator/Constraints/LengthValidator.php
	src/Symfony/Component/Validator/Tests/Constraints/AbstractComparisonValidatorTestCase.php
	src/Symfony/Component/Validator/Tests/Constraints/BlankValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/ChoiceValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/CollectionValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/DateTimeValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/DateValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/EmailValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/FalseValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/FileValidatorPathTest.php
	src/Symfony/Component/Validator/Tests/Constraints/FileValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/IbanValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/IpValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/IsbnValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/LengthValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/NullValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/RegexValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/TimeValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/TrueValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/UrlValidatorTest.php
webmozart added a commit that referenced this issue Aug 5, 2014
@webmozart
Merge branch '2.5'
27a2280 
* 2.5: (33 commits)
  [Validator] Added Swedish translations
  [Validator] Fixed ExpressionValidator when the validation root is not an object
  [Validator] Fixed: Made it possible (again) to pass a class name to Validator::validatePropertyValue()
  Fix incorrect romanian plural translations
  fix axes handling in Crawler::filterXPath()
  fix some docblocks
  Fixed self-reference in 'service_container' service breaks garbage collection (and clone).
  [Process] Fix tests when pcntl is not available.
  [DependencyInjection] Roll back changes made to generated files.
  [Console] Roll back changes made to fixture files.
  Issue #11489 Added some CA and ES translations
  [Validator] Added more detailed inline documentation
  [Validator] Removed information from the violation output if the value is an array, object or resource
  partially reverted previous commit
  fixed CS
  Add point about ConsoleLogger to Console 2.5 changelog
  [Validator] Fixed failing tests
  [Validator] CS fixes
  [FrameworkBundle] Made ConstraintValidatorFactory aware of the legacy validators
  [Validator] Added extensive test coverage for the constraint validators for the different APIs
  ...

Conflicts:
	src/Symfony/Component/Validator/Resources/translations/validators.ca.xlf
@collinsmao collinsmao mentioned this issue Aug 6, 2014
Closed
@Nyholm Nyholm mentioned this issue Aug 7, 2014
Merged
fabpot added a commit that referenced this issue Aug 8, 2014
@fabpot
minor #11608 [Validator] Added Swedish translations (78) (Nyholm)
56f934f 
This PR was merged into the 2.6-dev branch.

Discussion
----------

[Validator] Added Swedish translations (78)

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | part of #11489
| License       | MIT

Added the missing Swedish translations into master.

Commits
-------

d2bd92f [Validator] Added Swedish translations
This was referenced Aug 8, 2014
Closed
Closed
@1emming 1emming changed the title Call for people to add some translations for locale: af, ar, bg, ca, cy, da, de, el, et, eu, fa, fi, fr, gl, he, hr, hy, lb, mn, nb, no, ro, sq, sr_Cyrl, sr_Latn, sv, th, tr, uk, vi, zh_CN, zh_TW [Validator] Translations - Call for people to add some translations for locale: af, ar, bg, cy, da, el, et, eu, fa, fi, gl, he, hr, hy, id, lb, mn, nb, no, ro, sq, sr_Cyrl, sr_Latn, th, tr, uk, vi, zh_CH, zh_TW Aug 15, 2014
nicolas-grekas added a commit that referenced this issue Aug 18, 2014
@nicolas-grekas
minor #11674 [Validator] Add missing translation NL (1emming)
b674e67 
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #11674).

Discussion
----------

[Validator] Add missing translation NL

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | part of #11489
| License       | MIT

Commits
-------

2d5ab91 add missing options
@stof
Copy link
Member

stof commented Aug 18, 2014

@1emming could you provide similar tables for other translation files in Symfony. We have translations in the Security component (duplicated as of 2.4 for BC reasons) and in the Form component at least.

Regarding your table about the difference in the number of alternatives, it is not meaningful. The number of alternatives for pluralized messages is not expected to be the same for each locale. English needs 2 of them, while other locales need more (or even less as a few locales always need a single message). the max being 6 alternatives for ar.
the right validation would be to check whether the message is pluralized or no (i.e. is there alternatives in English) and then validating the number of alternatives in other locales based on the locale requirements. To know the requirements, you can have a look at https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Translation/PluralizationRules.php which gets the position of the alternative being used for a given locale (starting at 0 of course)

@stof stof added the Validator label Aug 18, 2014
@1emming 1emming closed this as completed Aug 22, 2014
sandergo90 pushed a commit to sandergo90/symfony that referenced this issue Jul 4, 2019
@webmozart
Merge branch '2.4' into 2.5
f7bca26 
* 2.4: (24 commits)
  [Validator] Added Swedish translations
  Fix incorrect romanian plural translations
  fix axes handling in Crawler::filterXPath()
  fix some docblocks
  Fixed self-reference in 'service_container' service breaks garbage collection (and clone).
  [Process] Fix tests when pcntl is not available.
  [DependencyInjection] Roll back changes made to generated files.
  [Console] Roll back changes made to fixture files.
  Issue symfony#11489 Added some CA and ES translations
  [Validator] Added more detailed inline documentation
  [Validator] Removed information from the violation output if the value is an array, object or resource
  partially reverted previous commit
  fixed CS
  properly handle null data when denormalizing
  [Validator] Renamed valueToString() to formatValue(); added missing formatValue() calls
  [Validator] Fixed CS
  [Validator] Fixed date-to-string conversion tests to match ICU 51
  [Validator] Added "{{ value }}" parameters where they were missing
  [Validator] Simplified and explained the LuhnValidator
  [Validator] Simplified IssnValidator
  ...

Conflicts:
	src/Symfony/Bridge/Propel1/Form/ChoiceList/ModelChoiceList.php
	src/Symfony/Component/HttpKernel/Debug/TraceableEventDispatcher.php
	src/Symfony/Component/Security/Core/Encoder/BasePasswordEncoder.php
	src/Symfony/Component/Validator/Constraints/ChoiceValidator.php
	src/Symfony/Component/Validator/Constraints/CollectionValidator.php
	src/Symfony/Component/Validator/Constraints/FileValidator.php
	src/Symfony/Component/Validator/Constraints/Isbn.php
	src/Symfony/Component/Validator/Constraints/IsbnValidator.php
	src/Symfony/Component/Validator/Constraints/LengthValidator.php
	src/Symfony/Component/Validator/Tests/Constraints/AbstractComparisonValidatorTestCase.php
	src/Symfony/Component/Validator/Tests/Constraints/BlankValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/ChoiceValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/CollectionValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/DateTimeValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/DateValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/EmailValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/FalseValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/FileValidatorPathTest.php
	src/Symfony/Component/Validator/Tests/Constraints/FileValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/IbanValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/IpValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/IsbnValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/LengthValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/NullValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/RegexValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/TimeValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/TrueValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/UrlValidatorTest.php
sandergo90 pushed a commit to sandergo90/symfony that referenced this issue Jul 4, 2019
@webmozart
Merge branch '2.5'
0ce70f5 
* 2.5: (33 commits)
  [Validator] Added Swedish translations
  [Validator] Fixed ExpressionValidator when the validation root is not an object
  [Validator] Fixed: Made it possible (again) to pass a class name to Validator::validatePropertyValue()
  Fix incorrect romanian plural translations
  fix axes handling in Crawler::filterXPath()
  fix some docblocks
  Fixed self-reference in 'service_container' service breaks garbage collection (and clone).
  [Process] Fix tests when pcntl is not available.
  [DependencyInjection] Roll back changes made to generated files.
  [Console] Roll back changes made to fixture files.
  Issue symfony#11489 Added some CA and ES translations
  [Validator] Added more detailed inline documentation
  [Validator] Removed information from the violation output if the value is an array, object or resource
  partially reverted previous commit
  fixed CS
  Add point about ConsoleLogger to Console 2.5 changelog
  [Validator] Fixed failing tests
  [Validator] CS fixes
  [FrameworkBundle] Made ConstraintValidatorFactory aware of the legacy validators
  [Validator] Added extensive test coverage for the constraint validators for the different APIs
  ...

Conflicts:
	src/Symfony/Component/Validator/Resources/translations/validators.ca.xlf
jderusse pushed a commit to jderusse/symfony that referenced this issue Dec 15, 2020
@webmozart
Merge branch '2.4' into 2.5
ddb81e9 
* 2.4: (24 commits)
  [Validator] Added Swedish translations
  Fix incorrect romanian plural translations
  fix axes handling in Crawler::filterXPath()
  fix some docblocks
  Fixed self-reference in 'service_container' service breaks garbage collection (and clone).
  [Process] Fix tests when pcntl is not available.
  [DependencyInjection] Roll back changes made to generated files.
  [Console] Roll back changes made to fixture files.
  Issue symfony#11489 Added some CA and ES translations
  [Validator] Added more detailed inline documentation
  [Validator] Removed information from the violation output if the value is an array, object or resource
  partially reverted previous commit
  fixed CS
  properly handle null data when denormalizing
  [Validator] Renamed valueToString() to formatValue(); added missing formatValue() calls
  [Validator] Fixed CS
  [Validator] Fixed date-to-string conversion tests to match ICU 51
  [Validator] Added "{{ value }}" parameters where they were missing
  [Validator] Simplified and explained the LuhnValidator
  [Validator] Simplified IssnValidator
  ...

Conflicts:
	src/Symfony/Bridge/Propel1/Form/ChoiceList/ModelChoiceList.php
	src/Symfony/Component/HttpKernel/Debug/TraceableEventDispatcher.php
	src/Symfony/Component/Security/Core/Encoder/BasePasswordEncoder.php
	src/Symfony/Component/Validator/Constraints/ChoiceValidator.php
	src/Symfony/Component/Validator/Constraints/CollectionValidator.php
	src/Symfony/Component/Validator/Constraints/FileValidator.php
	src/Symfony/Component/Validator/Constraints/Isbn.php
	src/Symfony/Component/Validator/Constraints/IsbnValidator.php
	src/Symfony/Component/Validator/Constraints/LengthValidator.php
	src/Symfony/Component/Validator/Tests/Constraints/AbstractComparisonValidatorTestCase.php
	src/Symfony/Component/Validator/Tests/Constraints/BlankValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/ChoiceValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/CollectionValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/DateTimeValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/DateValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/EmailValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/FalseValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/FileValidatorPathTest.php
	src/Symfony/Component/Validator/Tests/Constraints/FileValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/IbanValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/IpValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/IsbnValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/LengthValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/NullValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/RegexValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/TimeValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/TrueValidatorTest.php
	src/Symfony/Component/Validator/Tests/Constraints/UrlValidatorTest.php
jderusse pushed a commit to jderusse/symfony that referenced this issue Dec 15, 2020
@webmozart
Merge branch '2.5'
446920f 
* 2.5: (33 commits)
  [Validator] Added Swedish translations
  [Validator] Fixed ExpressionValidator when the validation root is not an object
  [Validator] Fixed: Made it possible (again) to pass a class name to Validator::validatePropertyValue()
  Fix incorrect romanian plural translations
  fix axes handling in Crawler::filterXPath()
  fix some docblocks
  Fixed self-reference in 'service_container' service breaks garbage collection (and clone).
  [Process] Fix tests when pcntl is not available.
  [DependencyInjection] Roll back changes made to generated files.
  [Console] Roll back changes made to fixture files.
  Issue symfony#11489 Added some CA and ES translations
  [Validator] Added more detailed inline documentation
  [Validator] Removed information from the violation output if the value is an array, object or resource
  partially reverted previous commit
  fixed CS
  Add point about ConsoleLogger to Console 2.5 changelog
  [Validator] Fixed failing tests
  [Validator] CS fixes
  [FrameworkBundle] Made ConstraintValidatorFactory aware of the legacy validators
  [Validator] Added extensive test coverage for the constraint validators for the different APIs
  ...

Conflicts:
	src/Symfony/Component/Validator/Resources/translations/validators.ca.xlf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Validator
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@javiereguiluz @sprain @stof @mmoreram @dcsg @wouterj @1emming @xabbuh