[DIC] Fixed: anonymous services are always private #11666
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
1 similar comment
|
👍 |
|
Thanks @lyrixx. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 14, 2014
This PR was squashed before being merged into the 2.5 branch (closes #11666). Discussion ---------- [DIC] Fixed: anonymous services are always private | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | This PR fix a regression introduce by 33c91f9#diff-c68f5120ea7d664e07e96cc40bdf6295L268 * First commit is just about CS * Second commit really fix the regression (see only this diff to easily understand) ping @sandermarechal @romainneutron Commits ------- 7f4f9ab [DIC] Fixed: anonymous services are always private
|
Closed via 35994bf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix a regression introduce by 33c91f9#diff-c68f5120ea7d664e07e96cc40bdf6295L268
ping @sandermarechal @romainneutron