Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SwiftmailerBridge] Bump allowed versions of swiftmailer #11892

Conversation

ymc-dabe
Copy link
Contributor

@ymc-dabe ymc-dabe commented Sep 9, 2014

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes (but SwiftmailerBridge itself does not contain any tests)
Fixed tickets -
License MIT
Doc PR -

Current version of Swiftmailer is 5.2.1, while (previously to this commit)
the version installed by composer was 5.0.3.

This is rather important, since 5.2.1 closes a security issue that 5.0.3 is
vulnarable to (swiftmailer/swiftmailer#494).

@ymc-dabe ymc-dabe force-pushed the SwiftmailerBridge-Bump-allowed-versions-of-swiftmailer branch from ae9add7 to 108b61a Compare September 9, 2014 15:03
@stof
Copy link
Member

stof commented Sep 10, 2014

IMO, all 5.x versions should be allowed given that Swiftmailer now follows semver

Current version of Swiftmailer is 5.2.1, while (previously to this commit)
the version installed by composer was 5.0.3.

This is rather important, since 5.2.1 closes a security issue that 5.0.3 is
vulnarable to (swiftmailer/swiftmailer#494).
@ymc-dabe ymc-dabe force-pushed the SwiftmailerBridge-Bump-allowed-versions-of-swiftmailer branch from 108b61a to a5e3fc9 Compare September 10, 2014 16:06
@ymc-dabe
Copy link
Contributor Author

I'm not sure if Swiftmailer follows semantic versioning, but I suspect it to. I therefore just updated the pull request to require ">=4.2.0,<6.0-dev" (instead of ">=4.2.0,<5.3-dev").
Thanks for the hint.

@stof
Copy link
Member

stof commented Sep 13, 2014

👍

@fabpot
Copy link
Member

fabpot commented Sep 13, 2014

Thank you @ymc-dabe.

@fabpot fabpot merged commit a5e3fc9 into symfony:2.3 Sep 13, 2014
fabpot added a commit that referenced this pull request Sep 13, 2014
…ymc-dabe)

This PR was merged into the 2.3 branch.

Discussion
----------

[SwiftmailerBridge] Bump allowed versions of swiftmailer

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes (but SwiftmailerBridge itself does not contain any tests)
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Current version of Swiftmailer is 5.2.1, while (previously to this commit)
the version installed by composer was 5.0.3.

This is rather important, since 5.2.1 closes a security issue that 5.0.3 is
vulnarable to (swiftmailer/swiftmailer#494).

Commits
-------

a5e3fc9 [SwiftmailerBridge] Bump allowed versions of swiftmailer
@fabpot
Copy link
Member

fabpot commented Sep 16, 2014

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants