[TwigBundle] properly set request attributes in controller test #12539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Nov 21, 2014
xabbuh
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
| @@ -122,7 +122,7 @@ protected function findTemplate(Request $request, $format, $code, $showException | |||
| // default to a generic HTML exception | |||
| $request->setRequestFormat('html'); | |||
|
|
|||
| return new TemplateReference('TwigBundle', 'Exception', $this->debug ? 'exception_full' : $name, 'html', 'twig'); | |||
| return new TemplateReference('TwigBundle', 'Exception', $name, 'html', 'twig'); | |||
There was a problem hiding this comment.
this change is wrong. It won't display the full exception template in debug mode when the original format was not HTML.
However, it should use $showException, not $this->debug
There was a problem hiding this comment.
Hm, this check is actually performed in line 103 before, isn't it? That's the reason I removed it here.
There was a problem hiding this comment.
Ah, you're right about the format.
xabbuh
force-pushed
the
fix-twig-bundle
branch
from
8facb9b
to
b3db574
Compare
|
👍 |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Nov 21, 2014
… test (xabbuh) This PR was merged into the 2.6 branch. Discussion ---------- [TwigBundle] properly set request attributes in controller test | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- b3db574 properly set request attributes in controller test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.