[Hackday] [Toolbar] Fix info position and icons on small screens #12649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanosala
changed the title
|
Here is a sample app to test the changes, thanks to Heroku ;) |
|
wow great PR experience, screenshots, heroku app to review it, thanks 👍 |
| @@ -11,7 +11,7 @@ | |||
| </service> | |||
|
|
|||
| <service id="data_collector.dump" class="Symfony\Component\HttpKernel\DataCollector\DumpDataCollector"> | |||
| <tag name="data_collector" id="dump" template="@Debug/Profiler/dump.html.twig" /> | |||
| <tag name="data_collector" id="dump" template="@Debug/Profiler/dump.html.twig" priority="285" /> | |||
There was a problem hiding this comment.
Why did you change all priorities?
There was a problem hiding this comment.
Sorry, I forgot to mention in the PR description. Basically only to allow more flexibility if a user wants to put something custom between collectors, but that's not strictly needed.
There was a problem hiding this comment.
Can you revert the priority changes?
added 2 commits
January 3, 2015 15:13
Place info div to not float out of the window
stefanosala
force-pushed
the
fix-profilers-orders
branch
from
c00ab5d
to
23c0ddc
Compare
|
@fabpot done! |
|
According to your sample app, there is some issues where some panels are getting smaller width than what they should on hover, making it impossible to read the content (look at the dump panel for instance) |
|
however, allowing icons to go on several lines when there is not enough space on 1 line to display the whole toolbar is a simple way to fix the issue of items disappearing |
|
@stof thanks, it wasn't easy, but I spotted the bug :) |
stefanosala
force-pushed
the
fix-profilers-orders
branch
from
caf4506
to
838857c
Compare
|
👍 |
|
Thank you @stefanosala. |
fabpot
added a commit
that referenced
this pull request
Jan 26, 2015
…creens (stefanosala) This PR was merged into the 2.6 branch. Discussion ---------- [Hackday] [Toolbar] Fix info position and icons on small screens | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12582 | License | MIT | Doc PR | - I changed a bit the order of profiles, IMO the dump goes closer to request data. Then I tweaked a bit the toolbar to show more icons even on smaller screen. I tested everything with Chrome and IE9 and it seems to work smoothly. Here are some explanatory screenshots:   Commits ------- 838857c [Toolbar] Reset right and left .sf-toolbar-info values needed for window resize 23c0ddc [Toolbar] Handle info position via javascript Place info div to not float out of the window 7a8582e [Toolbar] Display all icons, even on two lines for small screens
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
…small screens (stefanosala) This PR was merged into the 2.6 branch. Discussion ---------- [Hackday] [Toolbar] Fix info position and icons on small screens | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#12582 | License | MIT | Doc PR | - I changed a bit the order of profiles, IMO the dump goes closer to request data. Then I tweaked a bit the toolbar to show more icons even on smaller screen. I tested everything with Chrome and IE9 and it seems to work smoothly. Here are some explanatory screenshots:   Commits ------- 838857c [Toolbar] Reset right and left .sf-toolbar-info values needed for window resize 23c0ddc [Toolbar] Handle info position via javascript Place info div to not float out of the window 7a8582e [Toolbar] Display all icons, even on two lines for small screens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed a bit the order of profiles, IMO the dump goes closer to request data. Then I tweaked a bit the toolbar to show more icons even on smaller screen. I tested everything with Chrome and IE9 and it seems to work smoothly.
Here are some explanatory screenshots: