Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.6] Var dumper result is not shown in toolbar on not smaller screens #12582

Closed
wouterj opened this issue Nov 26, 2014 · 2 comments
Closed

[2.6] Var dumper result is not shown in toolbar on not smaller screens #12582

wouterj opened this issue Nov 26, 2014 · 2 comments

Comments

@wouterj
Copy link
Member

wouterj commented Nov 26, 2014

Since the toolbar is so full of stuff, the icons start to fall of the screen, starting with the var dumper. This makes it pretty hard to use it.

@wouterj wouterj changed the title Var dumper result is not shown in toolbar on not smaller screens [2.6] Var dumper result is not shown in toolbar on not smaller screens Nov 26, 2014
@weaverryan
Copy link
Member

Yea, and since the dump() icon shows up when you're purposefully doing something to make it show up, it should show up (at least as often as possible - if the bar is collapse, there's nothing we can do).

Should we just move the icon further to the left on the bar?

@stof
Copy link
Member

stof commented Jan 3, 2015

This is not only about the VarDumper. Changing the order of icons to put the VarDumper earlier wil not fix the issue. It will simply change the collector being impacted.

The issue is in the design of the toolbar, which has a fixed height allowing to render a single line of items but still allows items to move on a next line when they are too big. This requires reworking a bit the toolbar design and media queries.

fabpot added a commit that referenced this issue Jan 26, 2015
…creens (stefanosala)

This PR was merged into the 2.6 branch.

Discussion
----------

[Hackday] [Toolbar] Fix info position and icons on small screens

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #12582
| License       | MIT
| Doc PR        | -

I changed a bit the order of profiles, IMO the dump goes closer to request data. Then I tweaked a bit the toolbar to show more icons even on smaller screen. I tested everything with Chrome and IE9 and it seems to work smoothly.

Here are some explanatory screenshots:

![](http://cl.ly/image/3E2e360Y0a15/Screen%20Shot%202014-11-29%20at%2011.56.17.png)
![](http://cl.ly/image/1d073v2v2U2J/Screen%20Shot%202014-11-29%20at%2011.56.42.png)

Commits
-------

838857c [Toolbar] Reset right and left .sf-toolbar-info values needed for window resize
23c0ddc [Toolbar] Handle info position via javascript Place info div to not float out of the window
7a8582e [Toolbar] Display all icons, even on two lines for small screens
@fabpot fabpot closed this as completed Feb 10, 2015
ostrolucky pushed a commit to ostrolucky/symfony that referenced this issue Mar 25, 2018
…small screens (stefanosala)

This PR was merged into the 2.6 branch.

Discussion
----------

[Hackday] [Toolbar] Fix info position and icons on small screens

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | symfony#12582
| License       | MIT
| Doc PR        | -

I changed a bit the order of profiles, IMO the dump goes closer to request data. Then I tweaked a bit the toolbar to show more icons even on smaller screen. I tested everything with Chrome and IE9 and it seems to work smoothly.

Here are some explanatory screenshots:

![](http://cl.ly/image/3E2e360Y0a15/Screen%20Shot%202014-11-29%20at%2011.56.17.png)
![](http://cl.ly/image/1d073v2v2U2J/Screen%20Shot%202014-11-29%20at%2011.56.42.png)

Commits
-------

838857c [Toolbar] Reset right and left .sf-toolbar-info values needed for window resize
23c0ddc [Toolbar] Handle info position via javascript Place info div to not float out of the window
7a8582e [Toolbar] Display all icons, even on two lines for small screens
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants