-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.6] Var dumper result is not shown in toolbar on not smaller screens #12582
Comments
Yea, and since the Should we just move the icon further to the left on the bar? |
This is not only about the VarDumper. Changing the order of icons to put the VarDumper earlier wil not fix the issue. It will simply change the collector being impacted. The issue is in the design of the toolbar, which has a fixed height allowing to render a single line of items but still allows items to move on a next line when they are too big. This requires reworking a bit the toolbar design and media queries. |
…creens (stefanosala) This PR was merged into the 2.6 branch. Discussion ---------- [Hackday] [Toolbar] Fix info position and icons on small screens | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12582 | License | MIT | Doc PR | - I changed a bit the order of profiles, IMO the dump goes closer to request data. Then I tweaked a bit the toolbar to show more icons even on smaller screen. I tested everything with Chrome and IE9 and it seems to work smoothly. Here are some explanatory screenshots: ![](http://cl.ly/image/3E2e360Y0a15/Screen%20Shot%202014-11-29%20at%2011.56.17.png) ![](http://cl.ly/image/1d073v2v2U2J/Screen%20Shot%202014-11-29%20at%2011.56.42.png) Commits ------- 838857c [Toolbar] Reset right and left .sf-toolbar-info values needed for window resize 23c0ddc [Toolbar] Handle info position via javascript Place info div to not float out of the window 7a8582e [Toolbar] Display all icons, even on two lines for small screens
…small screens (stefanosala) This PR was merged into the 2.6 branch. Discussion ---------- [Hackday] [Toolbar] Fix info position and icons on small screens | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#12582 | License | MIT | Doc PR | - I changed a bit the order of profiles, IMO the dump goes closer to request data. Then I tweaked a bit the toolbar to show more icons even on smaller screen. I tested everything with Chrome and IE9 and it seems to work smoothly. Here are some explanatory screenshots: ![](http://cl.ly/image/3E2e360Y0a15/Screen%20Shot%202014-11-29%20at%2011.56.17.png) ![](http://cl.ly/image/1d073v2v2U2J/Screen%20Shot%202014-11-29%20at%2011.56.42.png) Commits ------- 838857c [Toolbar] Reset right and left .sf-toolbar-info values needed for window resize 23c0ddc [Toolbar] Handle info position via javascript Place info div to not float out of the window 7a8582e [Toolbar] Display all icons, even on two lines for small screens
Since the toolbar is so full of stuff, the icons start to fall of the screen, starting with the var dumper. This makes it pretty hard to use it.
The text was updated successfully, but these errors were encountered: