Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hackday] [2.7] Add a deprecation note about Validator's ApcCache #12665

Closed
javiereguiluz opened this issue Nov 29, 2014 · 1 comment
Closed

Comments

@javiereguiluz
Copy link
Member

NOTE: This issue is part of the "SymfonyCon 2014 Madrid Hackday" effort to add logs for every 2.7 deprecated feature. This is needed before removing those features in 3.0 version. Please, add you name in a comment of this issue if you are going to work on this.

If you need it, this Gist explains how to generate the deprecation note:

https://gist.github.com/javiereguiluz/a5514ec6cde2a63be441


The class Symfony\Component\Validator\Mapping\Cache\ApcCache has been removed in favor of Symfony\Component\Validator\Mapping\Cache\DoctrineCache.

Before:

use Symfony\Component\Validator\Mapping\Cache\ApcCache;

$cache = new ApcCache('symfony.validator');

After:

use Symfony\Component\Validator\Mapping\Cache\DoctrineCache;
use Doctrine\Common\Cache\ApcCache;

$apcCache = new ApcCache();
$apcCache->setNamespace('symfony.validator');

$cache = new DoctrineCache($apcCache);
@kbsali
Copy link
Contributor

kbsali commented Nov 29, 2014

i'll take that one.

kbsali added a commit to kbsali/symfony that referenced this issue Nov 29, 2014
kbsali added a commit to kbsali/symfony that referenced this issue Nov 29, 2014
kbsali added a commit to kbsali/symfony that referenced this issue Nov 29, 2014
fabpot added a commit that referenced this issue Nov 29, 2014
… (kbsali)

This PR was merged into the 2.7 branch.

Discussion
----------

[Validator] add deprecation log to class ApcCache (#12665)

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #12665
| License       | MIT
| Doc PR        |

This adds depreciation note for the Symfony\Component\Validator\Mapping\Cache\ApcCache class.

Commits
-------

881ed1e [Validator] add deprecation log (#12665)
@fabpot fabpot closed this as completed Nov 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants