[FrameworkBundle] Fix title and placeholder rendering in php form templates #13647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something went horribly wrong with travis. |
|
Thank you @jakzal. |
fabpot
added a commit
that referenced
this pull request
Feb 11, 2015
…hp form templates (jakzal) This PR was merged into the 2.3 branch. Discussion ---------- [FrameworkBundle] Fix title and placeholder rendering in php form templates Small fix for rendering placeholder on widgets in php templates. | Q | A | | ------------- | --- | | Bug fix? | yes | | New feature? | no | | BC breaks? | no | | Deprecations? | no | | Tests pass? | no | | Fixed tickets | - | | License | MIT | | Doc PR | - | This is a test case for #13290, including a fix applied on 2.3, since that's the earliest supported branch the bug exist. In 2.6 the template is a bit different, and unfortunately I couldn't re-use #13290's fix. When this is merged into 2.3, and then to 2.6 I think we can also merge #13290. Commits ------- f82193d [FrameworkBundle] Fix title and placeholder rendering in php form templates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix for rendering placeholder on widgets in php templates.
This is a test case for #13290, including a fix applied on 2.3, since that's the earliest supported branch the bug exist.
In 2.6 the template is a bit different, and unfortunately I couldn't re-use #13290's fix.
When this is merged into 2.3, and then to 2.6 I think we can also merge #13290.