Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[acl][command] User input option should always returned an array #13789

Closed
benjaminlong opened this issue Feb 25, 2015 · 0 comments
Closed

[acl][command] User input option should always returned an array #13789

benjaminlong opened this issue Feb 25, 2015 · 0 comments

Comments

@benjaminlong
Copy link
Contributor

Following command doesn't work

php acl:set --user=Symfony/Component/Security/Core/User/User:kevin VIEW EDIT Acme/MyClass:42

Indeed $userOption = $input->getOption('user'); return Symfony/Component/Security/Core/User/User:kevin instead of an array as further in the code we do foreach ($userOption as $user)
benjaminlong added a commit to benjaminlong/symfony that referenced this issue Feb 25, 2015
@benjaminlong
[acl][command][SecurityBundle] Fixed user input option mode to be an …
bd17ef8 
…Array

Fixed Issue symfony#13789
@benjaminlong benjaminlong mentioned this issue Feb 25, 2015
Merged
fabpot added a commit that referenced this issue Mar 14, 2015
@fabpot
bug #13790 [acl][command][SecurityBundle] Fixed user input option mod…
cc18a59 
…e to be an Array (benjaminlong)

This PR was merged into the 2.6 branch.

Discussion
----------

[acl][command][SecurityBundle] Fixed user input option mode to be an Array

| Q                       | A
| -------------            | ---
| Bug fix?            | yes
| New feature?   | no
| BC breaks?      | no
| Deprecations? | no
| Tests pass?     | yes
| Fixed tickets    | #13789
| License           | MIT
| Doc PR           |

User input option should always return an array, even if only one user is passed.

Commits
-------

bd17ef8 [acl][command][SecurityBundle] Fixed user input option mode to be an Array
@fabpot fabpot closed this as completed Mar 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabpot @benjaminlong