[HttpFoundation] Why is the default session name hardcoded?

[jasonbouffard]

https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpFoundation/SessionStorage/NativeSessionStorage.php#L46

I feel like we should pull the sesssion name from session_name() for the default session name. Because the rest of the default params for $cookieDefaults are pulled from php configuration.

[hhamon]

If you have a closer look at the code, there is an array_merge(). So you can override the session name from the configuration by changing the $options['name'] parameter.

[stloyd]

Please checkout session section of full framework config.

[jasonbouffard]

I'm aware we can set up the session name in the app config. My concern is that Symfony is not taking into consideration what a user may have set up in their php.ini or with php_value in an apache config like it does with all the params from session_get_cookie_params();. As you can see from this pull symfony/symfony-standard#94 we really should be configuring our session at the php level not the Symfony level. Hope that makes more sense where I was coming from on this one. Otherwise I really do appreciate all the work that went into Symfony2, it's awesome.

[stloyd]

@jpb0104 What do you think about mine proposal for fixing this issue ? The problem now is that if you even set up data in config.yml it will be ignored if option session.name in php.ini is not default one. I can change it but... I'm not sure is this good ;-)
Also skipping session_name() can give some "speed-up" to overall code execution...

[stof]

@stloyd If the user set a value explicitly in the configuration, it should be used.

[stloyd]

@jpb0104 Please check PR #1463.

[jasonbouffard]

Yep. PR #1463 looks good to me. At least the changes to NativeSessionStorage.php that are related to this bug.
We can close this issue if PR #1463 gets merged or hear otherwise.