[FrameworkBundle] Workaround php -S ignoring auto_prepend_file #14272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
fwk-fix23
branch
from
865eb2a
to
45c48bd
Compare
nicolas-grekas
force-pushed
the
fwk-fix23
branch
from
45c48bd
to
dcde445
Compare
|
What about |
|
auto_append_file is bugged also, but we can't do anything about it, there is no sane way to detect that the filewill not be included. |
|
Do we really need to support it here? Would it be better to just wait for the PHP bug fix? I mean, how many Symfony users are using this "weird" PHP feature anyway? |
|
I rely on this to have a consistent debugging env (think |
|
ping @symfony/deciders @symfony/mergers |
|
👍 |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 18, 2015
…file (nicolas-grekas) This PR was merged into the 2.3 branch. Discussion ---------- [FrameworkBundle] Workaround php -S ignoring auto_prepend_file | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - `php -S front_controller.php` (thus `php app/console server:run`) ignores auto_prepend_file for no reason. Commits ------- dcde445 [FrameworkBundle] Workaround php -S ignoring auto_prepend_file
| // Workaround https://bugs.php.net/64566 | ||
| if (ini_get('auto_prepend_file') && !in_array(realpath(ini_get('auto_prepend_file')), get_included_files(), true)) { | ||
| require ini_get('auto_prepend_file'); | ||
| } |
There was a problem hiding this comment.
this should be done only after the check for asset files IMO
There was a problem hiding this comment.
To be a real and exact workaround, we must replicate the behavior of the native feature, thus doing this first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php -S front_controller.php(thusphp app/console server:run) ignores auto_prepend_file for no reason.