Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debug] Scream as LogLevel::DEBUG (but for fatal errors / uncaught exceptions) #14362

Merged
merged 1 commit into from
Apr 18, 2015

Conversation

nicolas-grekas
Copy link
Member

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #14353
License MIT
Doc PR -

@lyrixx
Copy link
Member

lyrixx commented Apr 15, 2015

👍

@stof
Copy link
Member

stof commented Apr 15, 2015

what does it do exactly ?

@nicolas-grekas
Copy link
Member Author

Screaming is a feature that allows logging of @-silenced PHP errors. (e.g. @unlink($file))
In dev mode, screaming is enabled for all PHP error levels.
But in the logs we don't want a silenced PHP warning to come up as LogLevel::WARNING.
We'd prefer having to add -vv to app/console to see them

@stof
Copy link
Member

stof commented Apr 15, 2015

yeah, looks good to me. 👍

Btw, it would be great to fix the deps=low tests

@xabbuh
Copy link
Member

xabbuh commented Apr 15, 2015

@stof see #14344

@nicolas-grekas nicolas-grekas merged commit 3450122 into symfony:2.6 Apr 18, 2015
nicolas-grekas added a commit that referenced this pull request Apr 18, 2015
…uncaught exceptions) (nicolas-grekas)

This PR was merged into the 2.6 branch.

Discussion
----------

[Debug] Scream as LogLevel::DEBUG (but for fatal errors / uncaught exceptions)

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #14353
| License       | MIT
| Doc PR        | -

Commits
-------

3450122 [Debug] Scream as LogLevel::DEBUG (but for fatal errors / uncaught exceptions)
@nicolas-grekas nicolas-grekas deleted the scream-debug-log branch April 18, 2015 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants