Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[profiler][request toolbar] keep only action name in the toolbar icon. #14744

Closed
aitboudad opened this issue May 24, 2015 · 13 comments
Closed

[profiler][request toolbar] keep only action name in the toolbar icon. #14744

aitboudad opened this issue May 24, 2015 · 13 comments

Comments

@aitboudad
Copy link
Contributor

Before:

selection_009

After:

selection_010

@inso
Copy link

inso commented May 25, 2015

Action name is not unique, why not just keep route name?

@angusty
Copy link

angusty commented May 25, 2015

why?

@fabpot
Copy link
Member

fabpot commented May 25, 2015

I like the fact that you can quickly identify the executed request. 👎 from me.

@aitboudad
Copy link
Contributor Author

The toolbar icon should contains a little information and as you see in the screenshot it take 30% of the toolbar width which is wrong to me.
Is there another way to reduce the width of the request toolbar ?

@linaori
Copy link
Contributor

linaori commented May 25, 2015

I agree with both cases to be honest, working on 1440x900, with 2.7 I have a double rowed bar because it simply doesn't fit on there anymore, even with 2.6 I get this if the action names are very long. I use this feature to quickly trace back my current page to a certain controller and action.

What about showing MyController :: myAction and the route name when you hover over it? I know even this can be long, but 1/3 shorter on the average case. Another option would be to strip Controller and Action off, as they always contain those values anyway, but this might be confusing: My :: my

@phansys
Copy link
Contributor

phansys commented May 29, 2015

I like the @iltar's proposal.
The My :: my syntax shouldn't be confusing, indeed its similar which you use in some_route.defaults._controller in routing.yml by instance (just missing the bundle name part).
IMO, it would be nice to show also the request method on hover.

@ogizanagi
Copy link
Member

👍 about @iltar suggestion

@tgabi333
Copy link
Contributor

tgabi333 commented Jun 1, 2015

I would keep only the routing name, shows the controller and action on hover

@flip111
Copy link
Contributor

flip111 commented Jun 1, 2015

When displaying the method name the "Action" part of "changePasswordAction" can be removed.

@stof
Copy link
Member

stof commented Jun 1, 2015

I agree that we should find a shorter display for them to avoid taking 1/3 of the toolbar width just for this item (which causes issues when you have more items)

@xabbuh
Copy link
Member

xabbuh commented Jun 1, 2015

Stripping off Controller and Action sounds indeed like a good idea to me. What about also remove the route name here? You can see it when hovering the controller name and I assume most of the time you are more interested in finding the controller than the route name.

@linaori
Copy link
Contributor

linaori commented Jun 1, 2015

What about just showing the status, amount of requests + subrequests used in the bar and the rest when hovering?

@stevenmusumeche
Copy link

👍 to @iltar's suggestion

fabpot added a commit that referenced this issue Jun 8, 2015
…e toolbar (MJBGO)

This PR was merged into the 2.8 branch.

Discussion
----------

[profiler][request toolbar] Removed route name from the toolbar

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #14744
| License       | MIT
| Doc PR        |

The action block takes nearly 1/3 of the bar width which is not good.
The controller + action names are useful but the route name less important.

Before
![capture_before](https://cloud.githubusercontent.com/assets/8344487/8023606/325acb00-0d13-11e5-86db-ab2a08242227.PNG)

After
![capture_after](https://cloud.githubusercontent.com/assets/8344487/8023580/908edc22-0d11-11e5-92bd-37b380cc3433.PNG)

The route name is shown by hovering the action block
![capture_tooltip](https://cloud.githubusercontent.com/assets/8344487/8023584/a5ae08f8-0d11-11e5-97a5-ffec6d3e41cc.PNG)

Commits
-------

9004e29 Removed route name from the debugbar.
@fabpot fabpot closed this as completed Jun 8, 2015
ostrolucky pushed a commit to ostrolucky/symfony that referenced this issue Mar 25, 2018
…from the toolbar (MJBGO)

This PR was merged into the 2.8 branch.

Discussion
----------

[profiler][request toolbar] Removed route name from the toolbar

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | symfony#14744
| License       | MIT
| Doc PR        |

The action block takes nearly 1/3 of the bar width which is not good.
The controller + action names are useful but the route name less important.

Before
![capture_before](https://cloud.githubusercontent.com/assets/8344487/8023606/325acb00-0d13-11e5-86db-ab2a08242227.PNG)

After
![capture_after](https://cloud.githubusercontent.com/assets/8344487/8023580/908edc22-0d11-11e5-92bd-37b380cc3433.PNG)

The route name is shown by hovering the action block
![capture_tooltip](https://cloud.githubusercontent.com/assets/8344487/8023584/a5ae08f8-0d11-11e5-97a5-ffec6d3e41cc.PNG)

Commits
-------

9004e29 Removed route name from the debugbar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests