New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[profiler][request toolbar] keep only action name in the toolbar icon. #14744
Comments
Action name is not unique, why not just keep route name? |
why? |
I like the fact that you can quickly identify the executed request. 👎 from me. |
The toolbar icon should contains a little information and as you see in the screenshot it take 30% of the toolbar width which is wrong to me. |
I agree with both cases to be honest, working on 1440x900, with 2.7 I have a double rowed bar because it simply doesn't fit on there anymore, even with 2.6 I get this if the action names are very long. I use this feature to quickly trace back my current page to a certain controller and action. What about showing |
I like the @iltar's proposal. |
👍 about @iltar suggestion |
I would keep only the routing name, shows the controller and action on hover |
When displaying the method name the "Action" part of "changePasswordAction" can be removed. |
I agree that we should find a shorter display for them to avoid taking 1/3 of the toolbar width just for this item (which causes issues when you have more items) |
Stripping off |
What about just showing the status, amount of requests + subrequests used in the bar and the rest when hovering? |
👍 to @iltar's suggestion |
…e toolbar (MJBGO) This PR was merged into the 2.8 branch. Discussion ---------- [profiler][request toolbar] Removed route name from the toolbar | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14744 | License | MIT | Doc PR | The action block takes nearly 1/3 of the bar width which is not good. The controller + action names are useful but the route name less important. Before ![capture_before](https://cloud.githubusercontent.com/assets/8344487/8023606/325acb00-0d13-11e5-86db-ab2a08242227.PNG) After ![capture_after](https://cloud.githubusercontent.com/assets/8344487/8023580/908edc22-0d11-11e5-92bd-37b380cc3433.PNG) The route name is shown by hovering the action block ![capture_tooltip](https://cloud.githubusercontent.com/assets/8344487/8023584/a5ae08f8-0d11-11e5-97a5-ffec6d3e41cc.PNG) Commits ------- 9004e29 Removed route name from the debugbar.
…from the toolbar (MJBGO) This PR was merged into the 2.8 branch. Discussion ---------- [profiler][request toolbar] Removed route name from the toolbar | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#14744 | License | MIT | Doc PR | The action block takes nearly 1/3 of the bar width which is not good. The controller + action names are useful but the route name less important. Before ![capture_before](https://cloud.githubusercontent.com/assets/8344487/8023606/325acb00-0d13-11e5-86db-ab2a08242227.PNG) After ![capture_after](https://cloud.githubusercontent.com/assets/8344487/8023580/908edc22-0d11-11e5-92bd-37b380cc3433.PNG) The route name is shown by hovering the action block ![capture_tooltip](https://cloud.githubusercontent.com/assets/8344487/8023584/a5ae08f8-0d11-11e5-97a5-ffec6d3e41cc.PNG) Commits ------- 9004e29 Removed route name from the debugbar.
Before:
After:
The text was updated successfully, but these errors were encountered: