Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Deprecated Class+Interface from Map of Compiled Classes #14831

Closed
zanbaldwin opened this issue Jun 2, 2015 · 0 comments
Closed

Remove Deprecated Class+Interface from Map of Compiled Classes #14831

zanbaldwin opened this issue Jun 2, 2015 · 0 comments

Comments

@zanbaldwin
Copy link
Member

In the security bundle's extension class for Symfony v2.7.0 (and apparently still in master and 2.7 branches) there is still a reference to Symfony\Component\Security\Core\SecurityContext in a call to addClassesToCompile() on line 103 in file src/Symfony/Bundle/SecurityBundle/DependencyInjection/SecurityExtension.php.

Due to SexurityContext being included in the compiled classes.map and classes.php, two deprecated errors are thrown on every request (an extra one is thrown due to the inclusion of SecurityContextInterface which SecurityContext implements).

fabpot added a commit that referenced this issue Jun 2, 2015
…(Zander Baldwin)

This PR was merged into the 2.7 branch.

Discussion
----------

[2.7][SecurityBundle] Remove SecurityContext from Compile

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no change
| Fixed tickets | #14831
| License       | MIT
| Doc PR        | n/a

Remove the deprecated [SecurityContext](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Security/Core/SecurityContext.php) from the list of classes to compile into `classes.map` and `classes.php`. Prevents `E_USER_DEPRECATED` notices from being thrown on every request.

Commits
-------

1778e02 [2.7][SecurityBundle] Remove SecurityContext from Compile
@fabpot fabpot closed this as completed Jun 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants