-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FrameworkBundle] Reuse PropertyAccessor service for ObjectNormalizer #14989
Conversation
👍 |
Travis errors are unrelated. |
As the |
<!-- Normalizer --> | ||
<service id="serializer.normalizer.object" class="Symfony\Component\Serializer\Normalizer\ObjectNormalizer" public="false"> | ||
<argument type="service" id="serializer.mapping.class_metadata_factory" /> | ||
<argument>null</argument> | ||
<argument type="service" id="serializer.property_accessor" on-invalid="ignore" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if the on-invalid
parameter is still useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can remove it.
done |
Thank you @dunglas. |
…tNormalizer (dunglas) This PR was squashed before being merged into the 2.7 branch (closes #14989). Discussion ---------- [FrameworkBundle] Reuse PropertyAccessor service for ObjectNormalizer | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Inject the `property_accessor` service if available in the `ObjectNormalize` instead of creating a new instance. Commits ------- 256d441 [FrameworkBundle] Reuse PropertyAccessor service for ObjectNormalizer
Inject the
property_accessor
service if available in theObjectNormalize
instead of creating a new instance.