SymfonyStyle: Progress Bar Styling Logic Reversed ?

[weaverryan]

The SymfonyStyle::createProgressBar() currently looks like this:

    public function createProgressBar($max = 0)
    {
        $progressBar = parent::createProgressBar($max);
        if ('\\' === DIRECTORY_SEPARATOR) {
            $progressBar->setEmptyBarCharacter('░'); // light shade character \u2591
            $progressBar->setProgressCharacter('');
            $progressBar->setBarCharacter('▓'); // dark shade character \u2593
        }
        return $progressBar;
    }

The \\ is a check to see if we're in Windows. So, these styles are only shown in Windows. Is that backwards?

Ping @kbond I think this line originally came from your commit - maybe you remember what the issue was.

Thanks!

[kbond]

Right you are! Found this comment: #14057 (comment) - looks like I copied the fix wrong.