[MonologBridge] Monolog Bridge 2.8 is incompatible with HttpKernel 3.0 #16846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Can you also add a testcase covering the Logger class ? The fact that it is missing is the reason why it was not catched earlier. |
|
I'll do that, but I'd better submit the test in a separate PR against 2.3, I guess? |
|
See #16850 for the test case. |
|
👍 |
|
Thank you @derrabus. |
stof
added a commit
that referenced
this pull request
Dec 5, 2015
…tpKernel 3.0 (derrabus) This PR was merged into the 2.8 branch. Discussion ---------- [MonologBridge] Monolog Bridge 2.8 is incompatible with HttpKernel 3.0 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16837 | License | MIT | Doc PR | none Greetings from the SymfonyCon hackday. I wanted to start my day with an easy PR. 😉 As pointed out by @anlutro in #16837, MonologBridge 2.8 uses a deprecated interface of HttpKernel that has been removed in 3.0. Because of this, MonologBridge 2.8 must not be marked as compatible with HttpKernel 3.0 in composer.json. Commits ------- cb8d2c3 Disallow http-kernel 3.x, fixes #16837.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings from the SymfonyCon hackday. I wanted to start my day with an easy PR. 😉
As pointed out by @anlutro in #16837, MonologBridge 2.8 uses a deprecated interface of HttpKernel that has been removed in 3.0. Because of this, MonologBridge 2.8 must not be marked as compatible with HttpKernel 3.0 in composer.json.