[Process] More robustness and deterministic tests #17094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Dec 21, 2015
nicolas-grekas
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #16988, #15617 |
| License | MIT |
| Doc PR | - |
| @@ -46,6 +46,9 @@ public function __construct($script, $cwd = null, array $env = null, $timeout = | |||
| $php .= ' '.ProcessUtils::escapeArgument($file); | |||
| $script = null; | |||
| } | |||
| if ('\\' !== DIRECTORY_SEPARATOR) { | |||
| $php = 'exec '.$php; | |||
There was a problem hiding this comment.
OK for this as bug fix?
There was a problem hiding this comment.
yes, but please add a comment explaning what's this / link to existing issues
|
|
||
| $ptsWorkaround = null; | ||
| $commandline .= '{ ('.$this->commandline.') <&3 3<&- 3>/dev/null & } 3<&0;'; |
There was a problem hiding this comment.
could you add the link to the stackoverflow post explaining this command line?
nicolas-grekas
force-pushed
the
fix-process-test23
branch
5 times, most recently
from
9f2559d
to
5b1b962
Compare
| @@ -55,6 +61,9 @@ public function __construct($script, $cwd = null, array $env = null, $timeout = | |||
| */ | |||
| public function setPhpBinary($php) | |||
| { | |||
| if ('\\' !== DIRECTORY_SEPARATOR) { | |||
| $php = 'exec '.$php; | |||
There was a problem hiding this comment.
i'm going to remove this one because it breaks if anyone already prefix $php with exec
nicolas-grekas
force-pushed
the
fix-process-test23
branch
from
5b1b962
to
cdcd35d
Compare
nicolas-grekas
force-pushed
the
fix-process-test23
branch
from
cdcd35d
to
d1a178a
Compare
|
Nice job |
|
👍 |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Dec 23, 2015
…-grekas) This PR was merged into the 2.3 branch. Discussion ---------- [Process] More robustness and deterministic tests | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16988, #15617 | License | MIT | Doc PR | - Commits ------- d1a178a [Process] More robustness and deterministic tests
| $ptsWorkaround = null; | ||
| // See https://unix.stackexchange.com/questions/71205/background-process-pipe-input | ||
| $commandline .= '{ ('.$this->commandline.') <&3 3<&- 3>/dev/null & } 3<&0;'; | ||
| $commandline .= 'pid=$!; echo $pid >&3; wait $pid; code=$?; echo x$code >&3; exit $code'; |
There was a problem hiding this comment.
the old code had a p prefix before the pid, which is not there anymore. Does it still work fine ?
This was referenced Dec 26, 2015
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.