Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symfony\Component\Console\Application::renderException() should accept \Throwable #17257

Closed
ondrejmirtes opened this issue Jan 4, 2016 · 4 comments
Closed

Symfony\Component\Console\Application::renderException() should accept \Throwable #17257

ondrejmirtes opened this issue Jan 4, 2016 · 4 comments
Labels
Console Enhancement

Comments

@ondrejmirtes
Copy link
Contributor

Because of PHP 7, Symfony\Component\Console\Application::renderException() should also accept \Throwable type.
@Tobion
Copy link
Member

Tobion commented Jan 4, 2016

The same problem applies to HTTP request/response cycle with events (GetResponseForExceptionEvent). Ref #16980

@xabbuh xabbuh added the Console label Jan 4, 2016
@chalasr
Copy link
Member

chalasr commented Nov 6, 2016

I believe this issue has a duplicate #20110 and a PR #20111 (which would be nice to finish btw)

@keradus keradus mentioned this issue Dec 3, 2016
Closed
fabpot added a commit that referenced this issue Dec 5, 2016
@fabpot
bug #20736 [Console] fixed PHP7 Errors when not using Dispatcher (ker…
f9bceb8 
…adus)

This PR was squashed before being merged into the 2.7 branch (closes #20736).

Discussion
----------

[Console] fixed PHP7 Errors when not using Dispatcher

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #17257, #20110, #20111
| License       | MIT
| Doc PR        | n/a

Original fix, #19813, works only when there is event dispatcher available.
This PR fix the issue also for scenario without event dispatcher.

Closes #20110 issue and #20111 PR connected to it.
Closing #17257 , as everywhere the error is converted to exception and it should be handled

Commits
-------

899fa79 [Console] fixed PHP7 Errors when not using Dispatcher
@fabpot fabpot closed this as completed Dec 5, 2016
@xificurk
Copy link

xificurk commented Apr 14, 2017 •
edited

Please reopen this issue. It's not a duplicate of #20110 and also it's not yet fixed. PR #20111 added catching of Throwable, but the call to Application::renderException() still fails.

Update: nevermind, I see know that it's properly fixed in master.

@fabpot fabpot reopened this Apr 14, 2017
@chalasr
Copy link
Member

chalasr commented Apr 14, 2017 •
edited

This should be closed again (see edit on previous comment). Polished by Nicolas in #22435

@fabpot fabpot closed this as completed Apr 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Console Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@fabpot @javiereguiluz @ondrejmirtes @xificurk @Tobion @xabbuh @chalasr