[3.0.2]problem with buildForm (formtype)

[alex1442]

in ChoiceType::class
if expanded set to true then
parameter 'empty_data' ignored ,

validator return error not null for this value

a similar problem #17789
sf 3.0.2

[xabbuh]

Can you explain your issues a bit more and how it is even different from the referenced issue? The best would be to form the Symfony Standard Edition and make the changes needed to reproduce it.

[alex1442]

in ChoiceType::class, if expanded ===true ,validator return error :
This value should not be blank.
This value should not be null.,
but empty_value is defined.

class SearchMediaType extends AbstractType
{
    public function buildForm(FormBuilderInterface $builder, array $options)
    {
        $data = [ 'size' => 'thumbnail'];/ /defalt values
        $builder->setMethod('GET')
            ->add('tagName',  SearchType::class)
            ->add('size', ChoiceType::class, [
                'choices' => array('thumbnail' => 'thumbnail',
                'low_resolution' => 'low_resolution',
                'standard_resolution' => 'standard_resolution',
                ),
                'choices_as_values' => true,
                'multiple' => false,
                'expanded'=> TRUE,
                'empty_data' => $data['size']
                ]
            );

Size valus asserts:

//searchmediaentity.php
  /**
     * @Assert\NotBlank()
     * @Assert\NotNull()
     * @Assert\Choice({"thumbnail", "low_resolution", "standard_resolution"})
     */
    protected $size;

if expanded ===false then all right

soft info :
PHP 7.0.3-3+deb.sury.org~wily+1

composer.json:
{
    "name": "alex1442/3.0",
    "license": "proprietary",
    "type": "project",
    "autoload": {
        "psr-4": {
            "": "src/"
        },
        "files": [
            "app/AppKernel.php"
        ]
    },
    "autoload-dev": {
        "psr-4": {
            "Tests\\": "tests/"
        }
    },
    "require": {
        "php": ">=5.5.9",
        "symfony/symfony": "3.0.*",
        "doctrine/orm": "^2.5",
        "doctrine/doctrine-bundle": "^1.6",
        "doctrine/doctrine-cache-bundle": "^1.2",
        "symfony/swiftmailer-bundle": "^2.3",
        "symfony/monolog-bundle": "^2.8",
        "sensio/distribution-bundle": "^5.0",
        "sensio/framework-extra-bundle": "^3.0.2",
        "incenteev/composer-parameter-handler": "^2.0",
        "cosenary/instagram": "^2.3",
        "hirak/prestissimo": "^0.1.7"
    },
    "require-dev": {
        "sensio/generator-bundle": "^3.0",
        "symfony/phpunit-bridge": "^3.0"
    },
    "scripts": {
        "post-install-cmd": [
            "Incenteev\\ParameterHandler\\ScriptHandler::buildParameters",
            "Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::buildBootstrap",
            "Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::clearCache",
            "Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::installAssets",
            "Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::installRequirementsFile",
            "Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::prepareDeploymentTarget"
        ],
        "post-update-cmd": [
            "Incenteev\\ParameterHandler\\ScriptHandler::buildParameters",
            "Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::buildBootstrap",
            "Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::clearCache",
            "Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::installAssets",
            "Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::installRequirementsFile",
            "Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::prepareDeploymentTarget"
        ]
    },
    "extra": {
        "symfony-app-dir": "app",
        "symfony-bin-dir": "bin",
        "symfony-var-dir": "var",
        "symfony-web-dir": "web",
        "symfony-tests-dir": "tests",
        "symfony-assets-install": "relative",
        "incenteev-parameters": {
            "file": "app/config/parameters.yml"
        }
    }
}

[HeahDude]

Bug confirmed in 2.7, anytime expanded is true, either multiple is true or not.

I've found a fix in ChoiceType add this line 95 :

if (FormUtil::isEmpty($data)) {
    $data = $form->getConfig()->getEmptyData();
}

Status: reviewed

[HeahDude]

This issue comes from RadioListMapper and CheckboxListMapper IMHO, as they reset submitted data after Form::submit() has used empty_data.

I don't know if we can fix them without the "hack" above in the FormEvents::PRE_SUBMIT event when expanded is true.

[HeahDude]

Beware if you set empty_data as a callable you should use this code instead from line 93 of ChoiceType :

$builder->addEventListener(FormEvents::PRE_SUBMIT, function (FormEvent $event) {
    $form = $event->getForm();
    $data = $event->getData();

    if (FormUtil::isEmpty($data)) {
        $emptyData = $form->getConfig()->getEmptyData();
        if (is_callable($emptyData)) {
            $emptyData = call_user_func($emptyData, $form, $data);
        }
        $data = (string) $emptyData;
    }
    // ...

[HeahDude]

See #17822 for a cleaner fix.