Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DependencyInjection] Enable alias for service_container #17926

Merged
merged 1 commit into from
Mar 30, 2016

Conversation

hason
Copy link
Contributor

@hason hason commented Feb 25, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@xabbuh
Copy link
Member

xabbuh commented Feb 25, 2016

@hason Is this related to #17910 and #17915?

@hason
Copy link
Contributor Author

hason commented Mar 14, 2016

@xabbuh No

At present, ReplaceAliasByActualDefinitionPass class is coupled with configuration in FrameworkBundle. And that is the problem.

@xabbuh
Copy link
Member

xabbuh commented Mar 14, 2016

👍

Status: Reviewed

@fabpot
Copy link
Member

fabpot commented Mar 30, 2016

Thank you @hason.

@fabpot fabpot merged commit 6161438 into symfony:2.3 Mar 30, 2016
fabpot added a commit that referenced this pull request Mar 30, 2016
…hason)

This PR was merged into the 2.3 branch.

Discussion
----------

[DependencyInjection] Enable alias for service_container

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

6161438 [DependencyInjection] Enabled alias for service_container
@hason hason deleted the alias branch March 31, 2016 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants