[Process] getIncrementalOutput should work without calling getOutput #18023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
romainneutron
commented
Mar 5, 2016
romainneutron
commented
| Q | A |
|---|---|
| Branch | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #17937 |
| License | MIT |
| * @dataProvider provideVariousIncrementals | ||
| */ | ||
| public function testIncrementalOutputDoesNotRequiresAnotherCall($stream, $method) { | ||
| $process = new Process("php -r '\$n = 0; while (\$n < 3) { fwrite($stream, \$n, 1); \$n++; usleep(1000); }'", null, null, null, null); |
There was a problem hiding this comment.
please use self::$phpBin instead of php direclty as done elsewhere to enhance compatibility of tests with more runtimes
romainneutron
force-pushed
the
fix-17937
branch
2 times, most recently
from
38e4739
to
4bcfbc2
Compare
|
PR updated, comments addressed |
|
Arg, it fails on windows... |
romainneutron
force-pushed
the
fix-17937
branch
3 times, most recently
from
bd6aedb
to
260aeb2
Compare
| @@ -1166,6 +1166,31 @@ public function pipesCodeProvider() | |||
| } | |||
|
|
|||
| /** | |||
| * @dataProvider provideVariousIncrementals | |||
| */ | |||
| public function testIncrementalOutputDoesNotRequiresAnotherCall($stream, $method) { | |||
romainneutron
force-pushed
the
fix-17937
branch
from
260aeb2
to
31aca23
Compare
romainneutron
force-pushed
the
fix-17937
branch
from
31aca23
to
37d8695
Compare
|
👍 |
|
👍 |
|
Thank you @romainneutron. |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 17, 2016
… getOutput (romainneutron) This PR was merged into the 2.7 branch. Discussion ---------- [Process] getIncrementalOutput should work without calling getOutput | Q | A | ------------- | --- | Branch | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17937 | License | MIT Commits ------- 37d8695 [Process] getIncrementalOutput should work without calling getOutput
| * | ||
| * @param $caller The name of the method that needs fresh outputs | ||
| * | ||
| * @throw LogicException in case output has been disabled or process is not started |
stof
added a commit
that referenced
this pull request
Mar 17, 2016
This PR was merged into the 2.7 branch. Discussion ---------- [Process] fix docblock syntax | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18023 (comment) | License | MIT | Doc PR | Commits ------- f909fca [Process] fix docblock syntax
This was referenced Mar 25, 2016
Merged
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.