[router] Does not take additional GET parameter in account if it has a default value.

[Alsatian67]

In a Controller, I have two actions :

    /**
     * @Route("/search", name="search_with_default", defaults={"p"=1})
     */
    public function searchWithDefaultAction(Request $request)
    {
        return $this->render('default/index.html.twig');
    }

    /**
     * @Route("/search", name="search_without_default")
     */
    public function searchWithoutDefaultAction(Request $request)
    {
        return $this->render('default/index.html.twig');
    }

In twig, I generate routes to these actions with an additional GET parameter 'p' :

    {{ path('search_with_default',{'p':2}) }}<br/>
    {{ path('search_without_default',{'p':2}) }}

Result :

/app_dev.php/search
/app_dev.php/search?p=2 

The first one, totally ignore the value assigned on 'p'.

Bug reproduced here :

https://github.com/Alsatian67/symfony-standard

(index page shows the two paths)

[xabbuh]

Does this only happen if both routes are configured for the same path?

[Alsatian67]

No, that's just to show the bug. It is always so.

[hhamon]

I would say that's a normal behavior. The second argument of the path function is meant to replace the placeholders in the url patterns. So if the url doesn't have a {placeholder} but you have a default hardcoded value set, then it's taken. The extra GET parameters are only added for parameters / placeholders that are not defined in the route definition.

[Alsatian67]

I don't think it's normal.

Default means value when not defined.
So I can't immagine the default is overwriting the submitted one (as extra or not).

And when I enter an url with ?p=2 manually, the controller receives 2.

So this can not be intended by url generating and not when it retrives the parameter value.

[weaverryan]

It's weird because defaults is meant really to fill in the {wildcard} values. So the whole example looks strange - why add a defaults and then want to have query parameters added?

That being said, I would agree it's a bug - though really edge-case. The intention is that if there is no wildcard to fill in, the extra parameters are added as query parameters. In this case, the first route has no p wildcard, so I would also expect it to be added as a query parameter.

But again, it's weird :). You would fetch the p defaults value in a different way than the p query parameter: they're two different things entirely.

Btw @Alsatian67 thanks for the very clear report and fork - it's a weird situation, but very easy to understand!

[Tobion]

Duplicate of #10940

[Alsatian67]

@weaverryan

Let me explain my usage :

It's a search page with many optional parameters :

?page=1&name=&sortby=&date=&category= ...

Each of them are optional and mostly not used.

So I don't like a route like /{page}/{name}/{sortby} ...

But I want to set defaults like page = 1, name = "", sortby = "name"

;)