[DependencyInjection] fix ambiguous services schema

[backbone87]

Q	A
Branch?	2.3
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?
Fixed tickets	#17460 #2122
License	MIT

[javiereguiluz]

This issue seems very important. Could anyone who uses XML config verify it? Thanks! After all, people use XML because it validates the config ... so we must ensure that the validation is correct.

[xabbuh]

Best imo would be to have additional tests that ensure that an XML file that wasn't valid before now is parsed properly.

[stof]

@backbone87 can you add such a test ?

[backbone87]

if the XmlFileLoader is validating the loaded xml, then the schema should be covered by its test cases already?

[backbone87]

actually all the XmlFileLoader tests should fail without this ticket resolved, because the schema is invalid and therefore the xml cant be validated. i am not that familar with the validation behavior of libxml

[backbone87]

ok i have played around with the test cases of the XmlFileLoader and it seems like libxml doesnt care about unique particle attribution and therefore "succeeds" validating the services.xml files with the old (invalid) schema.
in general i have noticed some wacky applications of the whole validation, but i will open another issue for it.

in general the existing testcases cover that this PR is working as intented.

[xabbuh]

@backbone87 The thing is, if we cannot find an example that would fail without this change, there is no need to do it. So what I meant is that we need to find a failing example and have to add it on top of the already existing ones.

[backbone87]

@xabbuh it cant fail, because libxml doesnt seem to care about the problem in the XSD, but every other standards conforming tool reports this XSD as invalid without the fix

the "benefit" from this PR is that you can now have your extension config between parameter and service config, which was invalid before:

<parameters>...</parameter>
<project:config>...</project:config>
<services>...</services>

[backbone87]

i mean we could add a XSD linting test to the test suite, but that needs to use another XML tool than the ones bundled with PHP. every decent XSD editor lints automatically, so idk if its worth the hassle.

[backbone87]

whats missing here? any opinions on the latest comments?

[xabbuh]

The change itself looks good to me. 👍

But yeah I think we should use some external validation tool if that doesn't work properly with PHP.

[fabpot]

Thank you @backbone87.