Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bridge\PhpUnit] Workaround old phpunit bug, no colors in weak mode, add tests #18272

Merged
merged 1 commit into from
Mar 23, 2016
Merged

[Bridge\PhpUnit] Workaround old phpunit bug, no colors in weak mode, add tests #18272

merged 1 commit into from
Mar 23, 2016

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #18222
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas changed the title [Bridge\PhpUnit] Workaround old phpunit bug, no colors in weak mode, … [Bridge\PhpUnit] Workaround old phpunit bug, no colors in weak mode, add tests Mar 23, 2016
@nicolas-grekas nicolas-grekas merged commit 4ea9548 into symfony:2.7 Mar 23, 2016
nicolas-grekas added a commit that referenced this pull request Mar 23, 2016
@nicolas-grekas
bug #18272 [Bridge\PhpUnit] Workaround old phpunit bug, no colors in …
ec84aaf 
…weak mode, add tests (nicolas-grekas)

This PR was merged into the 2.7 branch.

Discussion
----------

[Bridge\PhpUnit] Workaround old phpunit bug, no colors in weak mode, add tests

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #18222
| License       | MIT
| Doc PR        | -

Commits
-------

4ea9548 [Bridge\PhpUnit] Workaround old phpunit bug, no colors in weak mode, add tests
@nicolas-grekas nicolas-grekas deleted the phpunit-test branch March 23, 2016 13:17
This was referenced Mar 25, 2016
Merged
Closed
Merged
Merged
@cjunge-work
Copy link

Since the 2.8.4 release, I am getting
Warning: Ambiguous class resolution, "Symfony\Bridge\PhpUnit\TextUI\TestRunner" was found in both "/var/www/api-admin/vendor/symfony/phpunit-bridge/TextUI/TestRunner.php" and "/var/www/api-admin/vendor/symfony/symfony/src/Symfony/Bridge/PhpUnit/TextUI/TestRunner.php", the first will be used.
Warning: Ambiguous class resolution, "Symfony\Bridge\PhpUnit\TextUI\Command" was found in both "/var/www/api-admin/vendor/symfony/phpunit-bridge/TextUI/Command.php" and "/var/www/api-admin/vendor/symfony/symfony/src/Symfony/Bridge/PhpUnit/TextUI/Command.php", the first will be used.
Warning: Ambiguous class resolution, "Symfony\Bridge\PhpUnit\DeprecationErrorHandler" was found in both "/var/www/api-admin/vendor/symfony/phpunit-bridge/DeprecationErrorHandler.php" and "/var/www/api-admin/vendor/symfony/symfony/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php", the first will be used.
Warning: Ambiguous class resolution, "Symfony\Bridge\PhpUnit\ClockMock" was found in both "/var/www/api-admin/vendor/symfony/phpunit-bridge/ClockMock.php" and "/var/www/api-admin/vendor/symfony/symfony/src/Symfony/Bridge/PhpUnit/ClockMock.php", the first will be used.
Warning: Ambiguous class resolution, "Symfony\Bridge\PhpUnit\SymfonyTestsListener" was found in both "/var/www/api-admin/vendor/symfony/phpunit-bridge/SymfonyTestsListener.php" and "/var/www/api-admin/vendor/symfony/symfony/src/Symfony/Bridge/PhpUnit/SymfonyTestsListener.php", the first will be used.

I assume it's related to this issue?

Based on the message shown it appears the old classes will be used, not the bug fix.

This was referenced Mar 31, 2016
Merged
Closed
fabpot added a commit that referenced this pull request Apr 1, 2016
@fabpot
minor #18389 Exclude Bridge\PhpUnit from composer.json by default (ni…
c5b792c 
…colas-grekas)

This PR was merged into the 2.7 branch.

Discussion
----------

Exclude Bridge\PhpUnit from composer.json by default

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #18381, #18272
| License       | MIT
| Doc PR        | -

Commits
-------

4f90495 Exclude Bridge\PhpUnit from composer.json by default
@xabbuh xabbuh mentioned this pull request Apr 12, 2016
Closed
greg0ire added a commit to greg0ire/symfony that referenced this pull request Sep 18, 2018
@greg0ire
Proivde debug_backtrace with proper args
66f2b2c 
This would fail if we were using strict mode with php 7, because true is
only a valid argument for php < 5.3.6.
This was changed from PHP_VERSION_ID >= 50400 ?
DEBUG_BACKTRACE_IGNORE_ARGS | DEBUG_BACKTRACE_PROVIDE_OBJECT : true in
 symfony#18272, but I do not understand why it was simlified, nor why
DEBUG_BACKTRACE_IGNORE_ARGS was there at that time.
@greg0ire greg0ire mentioned this pull request Sep 18, 2018
Merged
greg0ire added a commit to greg0ire/symfony that referenced this pull request Sep 18, 2018
@greg0ire
Provide debug_backtrace with proper args
3ffa6d1 
This would fail if we were using strict mode with php 7, because true is
only a valid argument for php < 5.3.6.
This was changed from PHP_VERSION_ID >= 50400 ?
DEBUG_BACKTRACE_IGNORE_ARGS | DEBUG_BACKTRACE_PROVIDE_OBJECT : true in
 symfony#18272, but I do not understand why it was simlified, nor why
DEBUG_BACKTRACE_IGNORE_ARGS was there at that time.
greg0ire added a commit to greg0ire/symfony that referenced this pull request Sep 18, 2018
@greg0ire
Provide debug_backtrace with proper args
cfe6ae1 
This would fail if we were using strict mode with php 7, because true is
only a valid argument for php < 5.3.6.
This was changed from PHP_VERSION_ID >= 50400 ?
DEBUG_BACKTRACE_IGNORE_ARGS | DEBUG_BACKTRACE_PROVIDE_OBJECT : true in
 symfony#18272, but I do not understand why it was simlified, nor why
DEBUG_BACKTRACE_IGNORE_ARGS was there at that time.
greg0ire added a commit to greg0ire/symfony that referenced this pull request Sep 19, 2018
@greg0ire
Provide debug_backtrace with proper args
0d826ae 
This would fail if we were using strict mode with php 7, because true is
only a valid argument for php < 5.3.6.
This was changed from PHP_VERSION_ID >= 50400 ?
DEBUG_BACKTRACE_IGNORE_ARGS | DEBUG_BACKTRACE_PROVIDE_OBJECT : true in
 symfony#18272, but I do not understand why it was simplified, nor why
DEBUG_BACKTRACE_IGNORE_ARGS was there at that time.
nicolas-grekas added a commit that referenced this pull request Sep 20, 2018
@nicolas-grekas
minor #28506 [PhpUnitBridge] Provide debug_backtrace with proper args…
4da7ab1 
… (greg0ire)

This PR was merged into the 2.8 branch.

Discussion
----------

[PhpUnitBridge] Provide debug_backtrace with proper args

This would fail if we were using strict mode with php 7, because true is
only a valid argument for php < 5.3.6.
This was changed from PHP_VERSION_ID >= 50400 ?
DEBUG_BACKTRACE_IGNORE_ARGS | DEBUG_BACKTRACE_PROVIDE_OBJECT : true in
 #18272, but I do not understand why it was simlified, nor why
DEBUG_BACKTRACE_IGNORE_ARGS was there at that time.

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Not sure if this qualifies as a bugfix. If not, should I simplify the ternary and target master? My fear is that having the code diverge too much will make it harder to merge subsequent PRs. I know this looks small, but I'm kind of preparing a big PR on the bridge and I'd rather have it smaller and easier to understand by moving everything I can with small patches like this one.

Commits
-------

0d826ae Provide debug_backtrace with proper args
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug PhpUnitBridge Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @cjunge-work @javiereguiluz @carsonbot