Serializer and Validator mappings don't use Bundle#getPath()

[wouterj]

Description

The bundle class has a getPath() method, allowing you to override the path of the bundle. However, inside the FrameworkExtension, $reflection->getFileName() is used to get the path to the bundle. This means that getPath() is ignored.

Use-case

In my case, my bundle directory structure looks like:

MyBundle/
  src/
    MyBundle.php
    ...
  Resources/
    config/
      serializer.yml
      validator.yml

In the MyBundle class, I override getPath() to return MyBundle/. This way, I would expect the serializer and validator configuration to be loaded. However, since they use reflection they're looking for MyBundle/src/Resources/config/serializer.yml.

Possible Solution

The auto-discovery of config files should be moved to a compiler pass. These have access to the bundle class instance (instead of FQCN) and can call ->getPath() on this instance instead of simulating the default behaviour of this method.

[chalasr]

👍 Same here, forced to use the default location.

@wouterj How would you access the bundle class instance in a compiler pass?
I mean without manually creating the instance from the FQCN (as it's possible to do in the FrameworkExtension).

[linaori]

I think one of my colleagues hit this bump when trying to register virtual bundles.

[linaori]

If I understand the issue correctly, the problem lies with the Bundle files being meta information and functional at the same time.

[chalasr]

Related SO question http://stackoverflow.com/questions/36714520/retrieve-bundle-class-instance-from-a-compiler-pass

[ro0NL]

@wouterj what about this approach?

[chalasr]

According to this line, this issue should concern the bundle's translations directory too.

Some solutions are actually proposed in #19606 and #19646 (Only tested with #19646 and it indeed fix it as it makes bundle instances available from any extension).

[ro0NL]

To clarify; this is also not about moving things from extensions to compilers (it could be legit though) as in both cases there's no context/service object/kernel/whatsoever available. Extensions are just part of a compiler.

[chalasr]

See #21113