Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed server status command when port has been omitted #18814

Closed
wants to merge 1 commit into from
Closed

Fixed server status command when port has been omitted #18814

wants to merge 1 commit into from

Conversation

peterrehm
Copy link
Contributor

@peterrehm peterrehm commented May 19, 2016

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #18810
License MIT
Doc PR -

Modified the status command to behave exactly as the server:start command. When the port is omitted in the address argument the default port is added from the port option.

@peterrehm
Copy link
Contributor Author

Actually I think this should be merged into 2.7.

@xabbuh
Copy link
Member

xabbuh commented May 19, 2016

👍

Status: Reviewed

@peterrehm Can you update the target branch in the PR description?

@javiereguiluz
Copy link
Member

👍

(updated the target branch)

@nicolas-grekas
Copy link
Member

Thank you @peterrehm.

nicolas-grekas added a commit that referenced this pull request May 20, 2016
…terrehm)

This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes #18814).

Discussion
----------

Fixed server status command when port has been omitted

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #18810
| License       | MIT
| Doc PR        | -

Modified the status command to behave exactly as the server:start command. When the port is omitted in the address argument the default port is added from the port option.

Commits
-------

94e4706 Fixed server status command when port has been omitted
@peterrehm peterrehm deleted the server-status branch May 24, 2016 06:56
@fabpot fabpot mentioned this pull request May 26, 2016
This was referenced Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants