[Debug] Do not quote numbers in stack trace

[c960657]

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	yes
Deprecations?	no
Tests pass?	yes
Fixed tickets
License	MIT
Doc PR

In the debug output from the exception handler, integers and floats are quoted. This adds unnecessary noise to the error page and is just wrong.

Fixing this requires introduces two new type descriptions in the output from getTrace(), so the change is not fully backwards compatible.

[fabpot]

missing empty line after the title

[fabpot]

What about just removing the (string) cast of the fallback. I think this should be enough.

[c960657]

@fabpot I'm not sure which cast you are referring to?

If we remove the cast in FlattenException::flattenArgs(), we will be labeling numbers as string, and such values are explicitly quoted in CodeExtension::formatArgs() and ExceptionHandler::formatArgs(). And it seems wrong to label numbers as strings.

If we remove the cast in CodeExtension::formatArgs() and ExceptionHandler::formatArgs(), we might as well remove the special case for string also and handle strings and numbers using the same var_export().

[fabpot]

In $formattedValue = str_replace("\n", '', var_export($this->escapeHtml((string) $item[1]), true));

[c960657]

Like this?

[c960657]

I also changed the flags for htmlspecialchars() in CodeExtension to avoid escaping the single-quotes generated by var_export(). This change is similar to that in #18841 (and probably should have been included in that fix).

[fabpot]

Yes! New integer and float types can be removed now.

[c960657]

It seems wrong to label integers and floats as string, doesn’t it?

[xabbuh]

This information should also be in the changelog.

[c960657]

@xabbuh I am confused about the branching/release strategy and how changes such as this one are handled. I suppose the change will be included in Symfony 3.2 (and no previous versions), right? Which changelog file should I add it to? The newest CHANGELOG file in the master branch is for 3.1.

[xabbuh]

Wer only have one changelog Liter (damn you auto-completion) per component. You can just start a new section by adding a new headline.

[c960657]

@xabbuh Done. I hope I got it right.

[fabpot]

@c960657 Right

[fabpot]

Thank you @c960657.