[Finder] ExcludeDirectoryFilterIterator does not like trailing slashes

[kassner]

Hi!

With PHPCPD (sebastianbergmann/phpcpd#135) I found out that ExcludeDirectoryFilterIterator does not exclude a directory if it is informed with a trailing slash (very common to happen if you're using bash autocomplete).

Looks like just rtrim($directory, '/') here will do the trick, but I was not able to assemble a unit test yet.

Any other approach to fix this?

Thanks!

[ro0NL]

Can you show what $directories looks like in your case? I think this makes sense :-)

[kassner]

@ro0NL

array(10) {
  [0]=>
  string(6) "tests/"
  [1]=>
  string(4) ".svn"
  [2]=>
  string(4) "_svn"
  [3]=>
  string(3) "CVS"
  [4]=>
  string(6) "_darcs"
  [5]=>
  string(12) ".arch-params"
  [6]=>
  string(9) ".monotone"
  [7]=>
  string(4) ".bzr"
  [8]=>
  string(4) ".git"
  [9]=>
  string(3) ".hg"
}

[ro0NL]

Here's the test 2.7...ro0NL:finder/rtrim-excluded-dirs

I can PR this if you want.. but maybe you have something going on already. The class is complex though.. i cant really visualize it how it works in recursive state (ie ::$isRecursive) as this is untested :-) (ie maybe it's only needed for the if part).

[kassner]

@ro0NL you can PR it, I'm not that far with my test.