Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FrameworkBundle] Support autowiring for RouterInterface #19972

Closed
wants to merge 1 commit into from
Closed

[FrameworkBundle] Support autowiring for RouterInterface #19972

wants to merge 1 commit into from

Conversation

hason
Copy link
Contributor

@hason hason commented Sep 19, 2016 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

lemoinem
lemoinem reviewed Sep 27, 2016
View reviewed changes
Copy link
Contributor

@lemoinem lemoinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, Thanks for the contribution.

Why use a new CompilerPass instead of simply adding the configuration at the definition of the router service in Resources/config/routing.xml?

@nicolas-grekas nicolas-grekas added this to the 3.x milestone Dec 6, 2016
@nicolas-grekas
Copy link
Member

Needs to be updated to account for #21494
Looks like this now just needs a few aliases in Resources/config/routing.xml.

Status: needs work

@nicolas-grekas
Copy link
Member

Closing, please submit a new PR using aliases if you'd like.

@nicolas-grekas nicolas-grekas modified the milestones: 3.x, 3.3 Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemoinem lemoinem lemoinem left review comments

Assignees
No one assigned
Labels
Feature FrameworkBundle Status: Needs Work
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
4 participants
@hason @nicolas-grekas @lemoinem @carsonbot