add missing use statement #20163
Merged
add missing use statement #20163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Oct 5, 2016
•
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | 996c1ee#commitcomment-19292581 |
| License | MIT |
| Doc PR |
|
@xabbuh you need to rebase your branch so that it starts from 2.7 too. Otherwise, you are asking us to merge the master branch codebase into 2.7, which won't happen |
|
@stof already done (I switched the branch here as I read @fabpot's command in #20116 (comment) too late) |
|
👍 |
1 similar comment
|
👍 |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Oct 5, 2016
This PR was merged into the 2.7 branch. Discussion ---------- add missing use statement | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | 996c1ee#commitcomment-19292581 | License | MIT | Doc PR | Commits ------- 32451b1 add missing use statement
This was referenced Oct 27, 2016
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.