Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow component only supports twig 1.x #21172

Closed
mvrhov opened this issue Jan 6, 2017 · 9 comments
Closed

Workflow component only supports twig 1.x #21172

mvrhov opened this issue Jan 6, 2017 · 9 comments
Labels
Workflow

Comments

@mvrhov
Copy link

mvrhov commented Jan 6, 2017 •
edited

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no
Symfony version 3.2
@mvrhov mvrhov changed the title Workwlow component only supports twig 1.x Workflow component only supports twig 1.x Jan 6, 2017
@stof
Copy link
Member

stof commented Jan 6, 2017

What is the issue with Twig 2 ?

@mvrhov
Copy link
Author

mvrhov commented Jan 6, 2017

As per require-dev it's only tested against 1.x branch

@xabbuh xabbuh added the Workflow label Jan 6, 2017
@stof
Copy link
Member

stof commented Jan 6, 2017

Well, it is tested against Twig 2 when running the fullstack testsuite on Travis, so it is working already. We should just update the constraint in the component

@fabpot
Copy link
Member

fabpot commented Jan 6, 2017

/cc @lyrixx

@lyrixx lyrixx mentioned this issue Jan 6, 2017
Merged
@lyrixx
Copy link
Member

lyrixx commented Jan 6, 2017

I just opened a PR

@mvrhov mvrhov closed this as completed Jan 6, 2017
fabpot added a commit that referenced this issue Jan 6, 2017
@fabpot
minor #21182 [Workflow] Removed twig from composer.json (dev section,…
e13f89b 
… not used) (lyrixx)

This PR was merged into the 3.2 branch.

Discussion
----------

[Workflow] Removed twig from composer.json (dev section, not used)

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21172
| License       | MIT
| Doc PR        | -

Commits
-------

4a81af6 [Workflow] Removed twig from composer.json (dev section, not used)
@Codenator81
Copy link

Codenator81 commented Jan 9, 2017 •
edited

@stof @fabpot Have issues with twig 2. It not works with debug panel

@Codenator81
Copy link

Codenator81 commented Jan 9, 2017 •
edited

just do composer update on standard project from symfony 3.2.1

Twig_Error_Syntax in exception.html.twig line 12:
Unknown "format_file_from_text" filter.

and I have errors with my Twig services because Twig_Function_Method and Twig_SimpleFilter removed from Twig. Fixed when change to Twig_Function and Twig_Filter

@lyrixx
Copy link
Member

lyrixx commented Jan 9, 2017

Hello @Codenator81

It has nothing to do with the workflow component. Could you open a new issue?

Thanks.

@Codenator81
Copy link

OK @lyrixx . Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Workflow
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@fabpot @lyrixx @stof @mvrhov @xabbuh @Codenator81