Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "bug #21791 [SecurityBundle] only pass relevant user provider (xabbuh)" #21798

Merged
merged 1 commit into from
Feb 28, 2017

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Feb 28, 2017

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #21791
License MIT
Doc PR

#21791 was a mistake as pointed out by @slaci (see #21791 (comment)) and @stof (see #21792 (comment)).

@nicolas-grekas
Copy link
Member

you should revert the merge commit (with git revert -m1 sha1)

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Feb 28, 2017
…ovider (xabbuh)"

This reverts commit eb750be, reversing
changes made to 70be4ba.
@xabbuh
Copy link
Member Author

xabbuh commented Feb 28, 2017

done

@nicolas-grekas nicolas-grekas changed the title Revert #21791 Revert "bug #21791 [SecurityBundle] only pass relevant user provider (xabbuh)" Feb 28, 2017
@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit f6637dd into symfony:2.7 Feb 28, 2017
nicolas-grekas added a commit that referenced this pull request Feb 28, 2017
…r provider (xabbuh)" (xabbuh)

This PR was merged into the 2.7 branch.

Discussion
----------

Revert "bug #21791 [SecurityBundle] only pass relevant user provider (xabbuh)"

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21791
| License       | MIT
| Doc PR        |

#21791 was a mistake as pointed out by @slaci (see #21791 (comment)) and @stof (see #21792 (comment)).

Commits
-------

f6637dd Revert "bug #21791 [SecurityBundle] only pass relevant user provider (xabbuh)"
@xabbuh xabbuh deleted the revert-21791 branch February 28, 2017 13:23
fabpot added a commit that referenced this pull request Mar 1, 2017
… (xabbuh)

This PR was merged into the 3.3-dev branch.

Discussion
----------

Revert "[SecurityBundle] only pass relevant user provider"

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21809, #21810
| License       | MIT
| Doc PR        |

This reverts commit d97e07f (applies #21798 on `master`). There is no merge commit that could be reverted.

Commits
-------

5b016ce Revert "[SecurityBundle] only pass relevant user provider"
This was referenced Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants