Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DomCrawler] HTML test doesn't pass #23858

Closed
matthieumota opened this issue Aug 10, 2017 · 0 comments
Closed

[DomCrawler] HTML test doesn't pass #23858

matthieumota opened this issue Aug 10, 2017 · 0 comments
Labels
DomCrawler

Comments

@matthieumota
Copy link
Contributor

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no
Symfony version master

Method testHtml use trim() but the string contains line break inside. I've mixed trim with a regexp. I can suggest this later in PR.
@matthieumota matthieumota mentioned this issue Aug 10, 2017
Closed
nicolas-grekas added a commit that referenced this issue Aug 14, 2017
@nicolas-grekas
minor #23859 [DomCrawler] Fix testHtml method with regexp (MatthieuMota)
993546b 
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #23859).

Discussion
----------

[DomCrawler] Fix testHtml method with regexp

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23858
| License       | MIT
| Doc PR        | no

As explained in this issue #23858, adding a regexp in addition to the trim for the testHtml method of [CrawlerTest](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/DomCrawler/Tests/CrawlerTest.php#L397) class.

Commits
-------

339592d Fix testHtml method with regexp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DomCrawler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nicolas-grekas @xabbuh @matthieumota