Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade 2.8 to 3.3 break #24718

Closed
symio opened this issue Oct 28, 2017 · 3 comments
Closed

upgrade 2.8 to 3.3 break #24718

symio opened this issue Oct 28, 2017 · 3 comments

Comments

@symio
Copy link

symio commented Oct 28, 2017

Q A
Bug report? yes
Feature request? no
BC Break report? yes
RFC? no
Symfony version 3.3.10

I just passed few hours trying to migrate my sf 2.8(.28) application to 3.3(.10) following both guides :

console commands server:* are lost, console is still in app directory not in bin, cache is still in app/cache no var/* directory has been created.

Comparing with a fresh 3.3.10 install do not come with an approaching file structure.
I, also, tried disabling all "specials" bundles needed in the project (fosuser, fosjsrouting, gedmo and stof doctrine-extensions, guzzle) but i always get the same result.

Also i remark that the "extra" section in composer.json is not updated like in a fresh install (no symfony-bin-dir as example).

Thanks for help and at least for reading

@mateuszsip
Copy link
Contributor

Hi @symio,
I will try to explain what's going on.

console commands server:* are lost

This is 3.3 related - http://symfony.com/blog/new-in-symfony-3-3-webserverbundle and not considered as BC Break. Requires configuration change (you need additional dependency), but don't change any of existing behaviors, so it's fine - UPGRADE files (like this for 3.3) include a list of changes that could be important for migration process..

console is still in app directory not in bin, cache is still in app/cache no var/* directory has been created.

Because new structure is just a new default - it cannot be migrated automatically, that's why manual changes are required.

I am responsible of migrating quite large symfony app since 2.4 (we're using 3.3 now) and experience is nice. Remember about UPGRADE in case of any problems.

And flex will bring many DX improvements, so stay tuned ;)

@chalasr
Copy link
Member

chalasr commented Oct 30, 2017

Going from 2.8 to 3.3 is a huge upgrade, you should have a look at UPGRADE-3.0 to UPGRADE-3.3 files, they are in the root directory of this repository.

About the directory structure, updating your dependencies cannot update it, that's up to you to keep it in sync with best practices.

For server:* commands, see the corresponding upgrade note:

The server:run, server:start, server:stop and server:status console commands have been moved to a dedicated bundle. Require symfony/web-server-bundle in your composer.json and register Symfony\Bundle\WebServerBundle\WebServerBundle in your AppKernel to use them.

@xabbuh
Copy link
Member

xabbuh commented Nov 2, 2017

I am going to close here as there is nothing we can actually change. But of course if you think that some of the upgrade instructions could be improved/clarified, please let us know.

@xabbuh xabbuh closed this as completed Nov 2, 2017
fabpot added a commit that referenced this issue Dec 11, 2017
…x (javiereguiluz)

This PR was merged into the 3.3 branch.

Discussion
----------

Added instructions to upgrade Symfony applications to 4.x

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

### Context

Related to #24718 and lots of past questions received in Slack, Stack Overflow, etc.

The UPGRADE guides are great for individual Symfony components/bundles, but we're lacking instructions to upgrade a whole Symfony app from 2.x to 3.x or from 3.x to 4.x.

In the past we had problems with the changes introduced in https://github.com/symfony/symfony-standard which were not documented in the main UPGRADE files.

### Proposal

We could:

1) Add a new section int he UPGRADE file to explain the upgrading process for whole Symfony apps. This is what this PR proposes (but it's still just a draft).
2) We could move the changes of this PR to a new article in the Symfony Docs.
3) We could move the entire UPGRADE files to the Symfony Docs and explain the changes for individual components and whole Symfony apps.
4) ... ?

Commits
-------

de4f8ac Added instructions to upgrade Symfony applications to 4.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants