[FrameworkBundle] Annotation cache does not override default settings

[Laizerox]

Q	A
Bug report?	yes
Feature request?	no
BC Break report?	no
RFC?	no
Symfony version	3.4.4

As the title describes when defined in config.yml

framework:
    annotations:
        cache: doctrine_cache.providers.annotations.cache

The annotation_reader does not get injected with proper cache but remains as ArrayCache.

The problem appears to happen when AddAnnotationsCachedReaderPass is being processed definition of annotations.cached_reader is already removed and $container->hasDefinition('annotations.cached_reader') returns false.

Default settings such as file for framework.annotations.cache does not appear to work either.

When default cache is being overridden in annotations.xml of FrameworkBundle manually it appears the cache starts to work.

When using bundles such as FOSRestBundle the lack of cache causes annotation_reader to parse annotations on each request.

Either I'm doing something wrong or this has broken at some stage.

[Laizerox]

I've concluded more testing and took a look at 7085569 commit.

It appears that the pass config type was changed from PassConfig::TYPE_BEFORE_REMOVING to PassConfig::TYPE_AFTER_REMOVING.

Now if I revert that change the cache provider will be injected accordingly.

I also noticed that there was a test added in that particular commit. However I believe its looking for a wrong definition and hence doesn't fail. Maybe it should be looking for test.annotations.cached_reader instead of test.annotation_reader @nicolas-grekas ?