Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session cookie set in "test" environment behind a stateless firewall #26493

Closed
romainneutron opened this issue Mar 12, 2018 · 0 comments
Closed

Session cookie set in "test" environment behind a stateless firewall #26493

romainneutron opened this issue Mar 12, 2018 · 0 comments
Labels
Bug HttpFoundation Status: Needs Review

Comments

@romainneutron
Copy link
Contributor

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no
Symfony version 3.4.5

I experience an issue in my app test suite : I test that no cookies are set behind a stateless firewall. In prod, it works, however in test env, it fails.

This is a regression that appeared in 3.4.5 and already appeared in the past. AFAIK @nicolas-grekas fixed it in late november, see #25219 and #25220
@nicolas-grekas nicolas-grekas mentioned this issue Apr 7, 2018
Merged
nicolas-grekas added a commit that referenced this issue Apr 14, 2018
@nicolas-grekas
bug #26857 [HttpKernel] Dont create mock cookie for new sessions in t…
16ae720 
…ests (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[HttpKernel] Dont create mock cookie for new sessions in tests

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #26493
| License       | MIT
| Doc PR        | -

@romainneutron can you please check if this fixes your issue?

Commits
-------

86b850e [HttpKernel] Dont create mock cookie for new sessions in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug HttpFoundation Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@romainneutron @nicolas-grekas @carsonbot