Translation escaping

[Tobion]

I know we discussed this earlier, but I'm still or again confused.
The documentation at http://symfony.com/doc/current/book/translation.html says

{# but static strings are never escaped #}
{{ '<h3>foo</h3>' | trans }}

which is wrong. Because it does get escaped. This is strange because the trans tag does on the other hand not escape.
So we get 2 different results for semantically the same stuff:

{% block title 'Me & you'|trans %}

is different from

{% block title %}
{% trans %}Me & you{% endtrans %}
{% endblock %}

[stloyd]

{{ '<h3>foo</h3>'|trans|raw }}

[Tobion]

I know but that does not resolve the documentation error or the Symfony bug.

[dlsniper]

@Tobion I could work on this but I'd rather know which approach should I take:

• fix the |trans method
• fix the {%trans%} method

Thanks!

[stof]

|trans behaves the right way IMO. There is absolutely no reason to consider that the translation string is safe.

[fabpot]

And the trans tag also works the right way as content outside expressions are never escaped by Twig. This is even documented. It's probably confusing but I'm against changing the current behavior at this point as it would be a major BC break.

I discussed that with @weaverryan a long time ago but I don't find the issue right now.

[wouterj]

If I understand this correct, we should change the documentation, saying that '<h3>foo</h3>|trans' get escaped?

[stof]

@wouterj yes