Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecurityBundle][DX] http://symfony.com/schema/dic/security schema is missing #28141

Closed
kaznovac opened this issue Aug 6, 2018 · 7 comments · Fixed by #36072
Closed

[SecurityBundle][DX] http://symfony.com/schema/dic/security schema is missing #28141

kaznovac opened this issue Aug 6, 2018 · 7 comments · Fixed by #36072
Labels
DX DX = Developer eXperience (anything that improves the experience of using Symfony) Feature SecurityBundle

Comments

@kaznovac
Copy link
Contributor

kaznovac commented Aug 6, 2018

Symfony version(s) affected: ^3|^4 (and possibly ^2)

Description
SecurityBundle references namespace 'http://symfony.com/schema/dic/security'
but it's xsd schema is missing. this is nice to have but not feature impeding.

How to reproduce
there are numerous references for 'http://symfony.com/schema/dic/security' in 'src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Fixtures/xml/*.xml'
and \Symfony\Bundle\SecurityBundle\DependencyInjection\SecurityExtension::getNamespace returns this namespace.

Possible Solution
provide schema for 'http://symfony.com/schema/dic/security', like the ones for services, twig xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd http://symfony.com/schema/dic/twig http://symfony.com/schema/dic/twig/twig-1.0.xsd"

@javiereguiluz javiereguiluz added SecurityBundle DX DX = Developer eXperience (anything that improves the experience of using Symfony) labels Aug 12, 2018
@javiereguiluz
Copy link
Member

@kaznovac sorry for the lack of response. I'm trying to fix this ... but I can't find the security.xsd or security-1.0.xsd file anywhere in Symfony's code. Do you know where I can find the XSD for http://symfony.com/schema/dic/security? Thanks.

@xabbuh
Copy link
Member

xabbuh commented Feb 18, 2019

As far as I know we do not have a schema definition file for the SecurityBundle config.

@kaznovac
Copy link
Contributor Author

@javiereguiluz I was suspecting that there is no schema, and @xabbuh confirmed that.

We need to write it (if structure defined in Symfony\Bundle\SecurityBundle\DependencyInjection\MainConfiguration allows it).
I can assist, hope I can find some time this weekend or the next one...

@Simperfit
Copy link
Contributor

@kaznovac did you find time to do this ?

@kaznovac
Copy link
Contributor Author

kaznovac commented Apr 7, 2019

@Simperfit sorry I haven't got much time lately (became a father 2.5 moths ago)

I've looked into it, scratched it out, and figured out that I need a XSD refresher course (how to import elements from another schema for providers, see this dynamic definition for providers section https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/SecurityBundle/DependencyInjection/MainConfiguration.php#L371-L376) ;)

Also Symfony Security rework #30914 can affect the form of the configuration/schema.

@Simperfit
Copy link
Contributor

Simperfit commented Apr 7, 2019 via email

@HeahDude
Copy link
Contributor

See #36072 which may add it in master.

@fabpot fabpot closed this as completed Mar 15, 2020
fabpot added a commit that referenced this issue Mar 15, 2020
…tion (HeahDude)

This PR was merged into the 5.1-dev branch.

Discussion
----------

[SecurityBundle] Added XSD for the extension configuration

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #28141
| License       | MIT
| Doc PR        | TODO

Commits
-------

66ac3f7 [SecurityBundle] Added XSD for the extension configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX DX = Developer eXperience (anything that improves the experience of using Symfony) Feature SecurityBundle
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants