-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WindowsPipes is not compatible with php 7.3 #28655
Comments
Can you please check if #28689 fixes your issue? |
Oh, and tell us what the error is if not? |
No, this fix did not help. With it logic looks more correct (tries new $i for all pipes, not only for second, for example), but it did not fix the problem. |
…ekas) This PR was merged into the 2.8 branch. Discussion ---------- [Process] fix locking of pipe files on Windows | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28655 | License | MIT | Doc PR | - Commits ------- d64bd3b [Process] fix locking of pipe files on Windows
Can I uninstall this package? |
Symfony/Process version(s) affected: 4.1.4
Description
PHP 7.3 allow
unlink()
'locked' file at Pipes/WindowsPipes.php#L57 and returntrue
.In result if start 2 processes one by one, second process will delete file of previous one.
Possible this is error in PHP, but I can't create good bug report for PHP developers.
How to reproduce
I use
fastest
to use with phpunit in async mode. If run 2+ tests, first always return error.Possible Solution
before
for ($i = 0;; ++$i) {
addplus replace
for ($i = 0;; ++$i) {
onfor (;; ++$i) {
Additional context
no
The text was updated successfully, but these errors were encountered: