Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle][HttpKernel] Symfony esi handling allows objects to be passed as parameters #2941

Closed
asm89 opened this issue Dec 21, 2011 · 2 comments

Comments

@asm89
Copy link
Contributor

asm89 commented Dec 21, 2011

The framework has support for rendering "esi" tags. The internal implementation allows to pass objects as parameters of render standalone tags. This is a problem, because if you switch to a real reverse proxy, the objects in the parameters will be nullified.

I think this behavior should be changed to allow users to switch more transparently between a real reverse proxy and the symfony2 implementation.

The problem probably lies in the generation of the _internal uri. The code uses the http_build_query() method that will not include objects with no public fields: https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/HttpKernel.php#L188. Parameters should only be scalars?

@lsmith77
Copy link
Contributor

lsmith77 commented Jan 1, 2012

imho we have to leave it as is for 2.0, but should simply disallow any non scalar parameters in 2.1

@fabpot fabpot closed this as completed in 254e49b Jan 2, 2012
@fabpot
Copy link
Member

fabpot commented Jan 23, 2012

This has been reverted as they are some legitimate uses of passing an object directly like exception management.

homer6 pushed a commit to homer6/symfony that referenced this issue Jan 23, 2012
…r attributes when calling render() to make the call works with or without a reverse proxy (closes symfony#2941)"

This reverts commit 254e49b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants