Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] Add the missing translations for the Slovenian ("sl") locale #30186

Closed
javiereguiluz opened this issue Feb 12, 2019 · 2 comments
Closed
Labels
Good first issue Ideal for your first contribution! (some Symfony experience may be required) Validator
Milestone

Comments

@javiereguiluz
Copy link
Member

javiereguiluz commented Feb 12, 2019

If you want to work on this issue, add a comment to assign it to yourself and let others know that this is already taken. Thanks!


Symfony version(s) affected: 3.4

Description

The src/Symfony/Component/Validator/Resources/translations/validators.sl.xlf file is missing the following translations compared to the original English file:

<trans-unit id="83">
    <source>This is not a valid UUID.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="84">
    <source>This value should be a multiple of {{ compared_value }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="85">
    <source>This Business Identifier Code (BIC) is not associated with IBAN {{ iban }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="86">
    <source>This value should be valid JSON.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="87">
    <source>This collection should contain only unique elements.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="88">
    <source>This value should be positive.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="89">
    <source>This value should be either positive or zero.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="90">
    <source>This value should be negative.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="91">
    <source>This value should be either negative or zero.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="92">
    <source>This value is not a valid timezone.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="93">
    <source>This password has been leaked in a data breach, it must not be used. Please use another password.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="94">
    <source>This value should be between {{ min }} and {{ max }}.</source>
    <target>...</target>
</trans-unit>

Possible Solution

A Pull Request must be sent to Symfony's 3.4 branch adding the missing translations.

Don't forget to take a quick look at the existing translations to use the same tone and style in the new translations.

Additional context

You have two ways to make this contribution:

1) Use the GitHub web interface to edit the translation and make the pull request.

  • It's recommended if you don't have any experience using Git in the terminal.
  • To do so, click here to edit the translation file and follow the given steps to create the pull request.

2) Use your own editor to edit the translation file and use the Git commands in the terminal to make the pull request.

  • It's the most common way to contribute to Symfony.
  • You need to download Symfony's code to your computer and follow the steps explained in this contribution guide

If you need any help during the contribution process, visit the #contribs channel on Symfony Slack where we'll be happy to help you.

@javiereguiluz javiereguiluz added Validator Good first issue Ideal for your first contribution! (some Symfony experience may be required) labels Feb 12, 2019
@javiereguiluz javiereguiluz added this to the 3.4 milestone Feb 12, 2019
@vudaltsov
Copy link
Contributor

Ping @petk :)

@petk
Copy link
Contributor

petk commented Nov 25, 2019

Thanks for the ping, update coming up for the Slovenian translation.

fabpot added a commit that referenced this issue Nov 30, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] Update Slovenian translations

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #30186
| License       | MIT
| Doc PR        | N/A

Hello, this fixes the #30186

Commits
-------

b2ae60a [Validator] Update Slovenian translations
@fabpot fabpot closed this as completed Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Ideal for your first contribution! (some Symfony experience may be required) Validator
Projects
None yet
Development

No branches or pull requests

4 participants