Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] Add the missing translations for the Albanian ("sq") locale #30187

Closed
javiereguiluz opened this issue Feb 12, 2019 · 1 comment
Closed
Labels
Good first issue Ideal for your first contribution! (some Symfony experience may be required) Validator
Milestone

Comments

@javiereguiluz
Copy link
Member

IMPORTANT: this issue is reserved for new contributors, because we want to give the opportunity to people who want to contribute to Symfony but never found the right issue to do that.

If you want to work on this issue, add a comment to assign it to yourself and let others know that this is already taken. Thanks!


Symfony version(s) affected: 3.4

Description

The src/Symfony/Component/Validator/Resources/translations/validators.sq.xlf file is missing the following translations compared to the original English file:

<trans-unit id="59">
    <source>This is not a valid International Bank Account Number (IBAN).</source>
    <target>...</target>
</trans-unit>
<trans-unit id="60">
    <source>This value is not a valid ISBN-10.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="61">
    <source>This value is not a valid ISBN-13.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="62">
    <source>This value is neither a valid ISBN-10 nor a valid ISBN-13.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="63">
    <source>This value is not a valid ISSN.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="64">
    <source>This value is not a valid currency.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="65">
    <source>This value should be equal to {{ compared_value }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="66">
    <source>This value should be greater than {{ compared_value }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="67">
    <source>This value should be greater than or equal to {{ compared_value }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="68">
    <source>This value should be identical to {{ compared_value_type }} {{ compared_value }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="69">
    <source>This value should be less than {{ compared_value }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="70">
    <source>This value should be less than or equal to {{ compared_value }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="71">
    <source>This value should not be equal to {{ compared_value }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="72">
    <source>This value should not be identical to {{ compared_value_type }} {{ compared_value }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="73">
    <source>The image ratio is too big ({{ ratio }}). Allowed maximum ratio is {{ max_ratio }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="74">
    <source>The image ratio is too small ({{ ratio }}). Minimum ratio expected is {{ min_ratio }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="75">
    <source>The image is square ({{ width }}x{{ height }}px). Square images are not allowed.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="76">
    <source>The image is landscape oriented ({{ width }}x{{ height }}px). Landscape oriented images are not allowed.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="77">
    <source>The image is portrait oriented ({{ width }}x{{ height }}px). Portrait oriented images are not allowed.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="78">
    <source>An empty file is not allowed.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="79">
    <source>The host could not be resolved.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="80">
    <source>This value does not match the expected {{ charset }} charset.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="81">
    <source>This is not a valid Business Identifier Code (BIC).</source>
    <target>...</target>
</trans-unit>
<trans-unit id="82">
    <source>Error</source>
    <target>...</target>
</trans-unit>
<trans-unit id="83">
    <source>This is not a valid UUID.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="84">
    <source>This value should be a multiple of {{ compared_value }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="85">
    <source>This Business Identifier Code (BIC) is not associated with IBAN {{ iban }}.</source>
    <target>...</target>
</trans-unit>

Possible Solution

A Pull Request must be sent to Symfony's 3.4 branch adding the missing translations.

Don't forget to take a quick look at the existing translations to use the same tone and style in the new translations.

Additional context

You have two ways to make this contribution:

1) Use the GitHub web interface to edit the translation and make the pull request.

  • It's recommended if you don't have any experience using Git in the terminal.
  • To do so, click here to edit the translation file and follow the given steps to create the pull request.

2) Use your own editor to edit the translation file and use the Git commands in the terminal to make the pull request.

  • It's the most common way to contribute to Symfony.
  • You need to download Symfony's code to your computer and follow the steps explained in this contribution guide

If you need any help during the contribution process, visit the #contribs channel on Symfony Slack where we'll be happy to help you.

@javiereguiluz javiereguiluz added Validator Good first issue Ideal for your first contribution! (some Symfony experience may be required) labels Feb 12, 2019
@javiereguiluz javiereguiluz added this to the 3.4 milestone Feb 12, 2019
@fatonh
Copy link
Contributor

fatonh commented Feb 12, 2019

I'll take this one :)

fatonh added a commit to fatonh/symfony that referenced this issue Feb 12, 2019
symfony#30187 Added the missing translations for the Albanian language
@fabpot fabpot closed this as completed Feb 13, 2019
fabpot added a commit that referenced this issue Feb 13, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

Update validators.sq.xlf

#30187 Added the missing translations for the Albanian language

| Q             | A
| ------------- | ---
| Branch?       |  3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30187
| License       | MIT

This PR addresses the issue #30187, adding the missing translations for the Albanian (sq) locale.

Commits
-------

62b226e Update validators.sq.xlf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Ideal for your first contribution! (some Symfony experience may be required) Validator
Projects
None yet
Development

No branches or pull requests

3 participants