Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Messenger] refactoring to get rid of SendersLocatorInterface::getSenderByAlias #32077

Closed
Tobion opened this issue Jun 18, 2019 · 1 comment · Fixed by #34185
Closed

[Messenger] refactoring to get rid of SendersLocatorInterface::getSenderByAlias #32077

Tobion opened this issue Jun 18, 2019 · 1 comment · Fixed by #34185

Comments

@Tobion
Copy link
Member

Tobion commented Jun 18, 2019

Refactoring idea: Move the ReceivedStamp and RedeliveryStamp logic from the SendMessageMiddleware into the SendersLocator (or a decorator of it).
This avoids the need of requiring a SendersLocatorInterface::getSenderByAlias method and makes the code cleaner.

@Tobion
Copy link
Member Author

Tobion commented Jul 26, 2019

Another idea: Inject the failed SenderInterface into the SendFailedMessageToFailureTransportListener instead of the MessageBusInterface.
If we also send retry messages directly to the sender instead of redispatching in the worker, we don't need \Symfony\Component\Messenger\Stamp\RedeliveryStamp::getSenderClassOrAlias all all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants