Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in TimeType, derive view_timezone from model_timezone #32805

Closed
xabbuh opened this issue Jul 30, 2019 · 1 comment · Fixed by #35205
Closed

in TimeType, derive view_timezone from model_timezone #32805

xabbuh opened this issue Jul 30, 2019 · 1 comment · Fixed by #35205
Labels
Feature Form

Comments

@xabbuh
Copy link
Member

xabbuh commented Jul 30, 2019

In Symfony 5.1 we could further improve DX for the TimeType by deriving the view_timezone option from the configured model_timezone.
@xabbuh xabbuh mentioned this issue Jul 30, 2019
Merged
@xabbuh xabbuh mentioned this issue Jan 4, 2020
Merged
@xabbuh
Copy link
Member Author

xabbuh commented Jan 4, 2020

see #35205

@fabpot fabpot closed this as completed Jan 7, 2020
fabpot added a commit that referenced this issue Jan 7, 2020
@fabpot
feature #35205 [Form] derive the view timezone from the model timezon…
c29b2a1 
…e (xabbuh)

This PR was merged into the 5.1-dev branch.

Discussion
----------

[Form] derive the view timezone from the model timezone

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #32805
| License       | MIT
| Doc PR        |

Commits
-------

ef5835d derive the view timezone from the model timezone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Form
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Form] derive the view timezone from the model timezone xabbuh/symfony
2 participants
@fabpot @xabbuh