Improve the HttpClient panel in the Web Profiler

[nicolas-grekas]

PR #33015 introduces a profiler panel for the HttpClient component.
It was decided to merge it and improve it in nex iterations.

Here are the ideas that would be great to contribute, help wante:

• the panel UI could be improved I suppose, e.g. a tooltip on hover in the toolbar
• putting requests in the "Performance" tab would be great (all timings are already in the collected "info")
• response bodies are not collected yet [HttpClient] collect the body of responses when possible #35407
• when a transport error occurs, (ie the "error" info is populated) we should maybe have a better display too?
• add a copy-as-curl button next to each request [HttpClient][WebProfilerBundle] Add button to copy a request as a cURL command #43931

[Neirda24]

To improve DX, what if we parse the headers in the response and detect the debug token link to display it. WDYT ?

[stof]

@Neirda24 that's indeed a good idea.

[k0d3r1s]

i have a guzzle collector but I couldn't fit httpclient datacollector data into it. how much is it possible to change what this collector already does and how it collects data?

[derrabus]

add a copy-as-curl button next to each request

I could really use that feature now. 🙈

[derrabus]

Another idea for the profiler: If the API answers in JSON, we could try to parse and pretty-print it. Right now, I receive a string response_content that is a little hard to read.

[Neirda24]

Maybe with a two tabs solution ? One RAW and one PARSED. It could be JSON or XML

[michaelKaefer]

Info: since it got the labels Good first issue and Help wanted I start to work on the remaining tasks.

[michaelKaefer]

I hope someone can guide me on implementing this task: putting requests in the "Performance" tab would be great (all timings are already in the collected "info")

The times in the "Performance" tab are measured by calling Stopwatch::start() and Stopwatch::stop() (so I suppose this has to be done for every request and the collected "info" does not help here).

The Stopwatch::start() can be called in TraceableHttpClient::request() or somewhere in TraceableResponse. But where do we know that the response is complete so that we can call Stopwatch::stop()? I tried to use the on_progress callback but that does not work since we never know if it is the last call of the callback. I also tried Response::getContent() but that does not work if the client code never calls $response->getContent().

[erickr]

@michaelKaefer did you get going on this? I'm also interested to learn more, perhaps we can dig together if you want some assistance or sparring of course.. 😎

[jderusse]

@michaelKaefer , @erickr the StopWatch has already been implemented #38688

[michaelKaefer]

So I am out here. Current state:

• the panel UI could be improved I suppose, e.g. a tooltip on hover in the toolbar
• putting requests in the "Performance" tab would be great (all timings are already in the collected "info") [HttpClient] Add a Stopwatch on TraceableHttpClient #38688
• response bodies are not collected yet [HttpClient] collect the body of responses when possible #35407
• when a transport error occurs, (ie the "error" info is populated) we should maybe have a better display too?
• add a copy-as-curl button next to each request ---> Started here and taken by @derrabus

[carsonbot]

Thank you for this issue.
There has not been a lot of activity here for a while. Has this been resolved?

[derrabus]

Not yet, @carsonbot!

[ankahla]

As menstionned here #33311 (comment) guzzle output the request headers (including default headers in configuration).
@nicolas-grekas even with this PR #35407 we still not collecting all headers (headers defined in configuration are missing).
I think we need to expose defaultHeaders and get them from HttpClientTrait directly.

[abdellahrk]

Hello devs, any issue here still not solved yet? I'll like to jump in.
Thank you.

[nicolas-grekas]

I think we're done here, no need to keep this issue open. PR welcome of course if you have ideas to improve the panel!